Closed loran-steinberger closed 5 years ago
I believe we have tests covering this. There are some integration tests that are disabled but can be run locally (some of them are designed to actually interact with s3, Box, or whatever store you are working with) Also I'm not sure what is standard practice with versioning, but I would think we probably want to bump the version number for any change
Agree with Matt on version bump.
if you are changing a public signature it should be a version bump
I believe we have tests covering this. There are some integration tests that are disabled but can be run locally (some of them are designed to actually interact with s3, Box, or whatever store you are working with)
@matthewgraf I set up tests to run against Minio (dockerized S3) so S3 tests are running in travis (I filed issue #25 to fix codecov publishing).
Agree we should bump version.
Otherwise this looks good to me.
Agree we should bump version.
@rolandomanrique where is the version changed? I was looking over this with @lumengxi and it looks like the version in version.sbt
is out of sync with the latest on Sonatype as well as the latest in the repo "Releases" tab
Reconciling all version references to the same- 0.3.0
TODO: bump the version.
Relevant:
Q: How much data can I store in Amazon S3?
The total volume of data and number of objects you can store are unlimited. Individual Amazon S3 objects can range in size from a minimum of 0 bytes to a maximum of 5 terabytes. The largest object that can be uploaded in a single PUT is 5 gigabytes. For objects larger than 100 megabytes, customers should consider using the Multipart Upload capability.
AWS guidance is use TransferManager/Mulitpart upload for anything over 100mb