search

leng-yue / py-scrcpy-client

An easy to use python scrcpy client
https://leng-yue.github.io/py-scrcpy-client/
MIT License
283 stars 71 forks source link

Fix ci #61

Closed aentwist closed 2 months ago

aentwist commented 2 months ago

I hope this shores up the CI. What do you think @leng-yue ?

Besides fixing the python version inconsistencies I created, I think the python 3.7 macos-latest job failed because of this: https://github.com/actions/setup-python/issues/808

It looks like a new macos-latest was introduced that didn't have support for python <3.10. In the issue they mention it should be supported now, but they don't really talk about anything less than 3.8. Fortunately, that's our new minimum.

Although it might not be necessary, I hope that upgrading the setup-python actions to v5 guarantees this is fixed. My understanding of that is very surface level, but hopefully I don't need to go any deeper.

aentwist commented 2 months ago

Investigating the flake8 issue

Edit:

https://stackoverflow.com/questions/73929564/entrypoints-object-has-no-attribute-get-digital-ocean

I decided to just upgrade it from 4 to 7, which did the trick. This caused the required python min version to raise from 3.8.0 to 3.8.1

aentwist commented 2 months ago

@leng-yue , I hate to bother you so much but would you mind retrying the pipeline on main? It looks like it randomly died, from what appears to hopefully be a network error. I need to make sure there is nothing else I need to fix 😅