search

lengstrom / fast-style-transfer

TensorFlow CNN for fast style transfer ⚡🖥🎨🖼
10.91k stars 2.6k forks source link

TensorFlow 2.0 Implementation #225

Closed justinrmiller closed 4 years ago

justinrmiller commented 4 years ago

Greetings,

I have an implementation of evaluate.py and associated libraries that I've converted to TensorFlow 2.0. Would you be interested in potentially merging this in or would you prefer I create a separate project for that?

Thanks, Justin

lengstrom commented 4 years ago

That would be awesome! I am happy to help as well.

On Wed, Jan 22, 2020 at 6:32 PM Justin Miller notifications@github.com wrote:

Greetings,

I have an implementation of evaluate.py and associated libraries that I've converted to TensorFlow 2.0. Would you be interested in potentially merging this in or would you prefer I create a separate project for that?

Thanks, Justin

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/lengstrom/fast-style-transfer/issues/225?email_source=notifications&email_token=AAFZYILC64D2SMSTW7EVM63Q7DJRTA5CNFSM4KKOINSKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IIDFP5Q, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFZYIMP6Y6G7QGWT6DBMXDQ7DJRTANCNFSM4KKOINSA .

Akirakato1 commented 4 years ago

Do you happened to have changed style.py for tf 2.0 too?

justinrmiller commented 4 years ago

I will try to get that going as well and also test the evaluate file with video files.

naveen-annam commented 4 years ago

I will try to get that going as well and also test the evaluate file with video files.

@justinrmiller hey justin. Any update on this?. Didn't have much luck converting it to use 2.0. Would be really helpful if you update this somewhere with 2.0.

justinrmiller commented 4 years ago

Sorry things have been a bit busy lately. I will try to get a PR together this weekend. I have not tested video or model training but will try to do that soon.

naveen-annam commented 4 years ago

@justinrmiller Ahh no worries. Managed to update with 2.0 code. https://github.com/lengstrom/fast-style-transfer/pull/239. Got it to work with @divisiondeariza scipy fix and using the utility.

justinrmiller commented 4 years ago

Yeah it looks like you went with a strategy similar to mine and applied the TF2 upgrade tool. The only other change I had to make it make it work was around “.value” which it looks like you’ve taken care of as well. Good work!

rmasiso commented 4 years ago

@naveen-annam @justinrmiller How did you use the TF2 upgrade tool?

justinrmiller commented 4 years ago

@naveen-annam Looks like your PR got merged down, going to close this one down. Thanks!