search

lenhardt-its / ansible-role-adguard-home

MIT License
1 stars 3 forks source link

WIP: resolving deprecation issues in systemd unit and in adguard config file #5

Open fkonradmain opened 4 months ago

fkonradmain commented 4 months ago

solving #3 and #4 as provided in these comments.

The PR is still WIP, because my degree of customizing is too high to be merged into master in its current state.

OnkelDom commented 4 months ago

Hi @fkonradmain , many thanks for your pull-request. Have you testet your changes, that i can merge the pr?

fkonradmain commented 4 months ago

Hi @fkonradmain , many thanks for your pull-request. Have you testet your changes, that i can merge the pr?

Not to the necessary extent. There are several TODOs to be resolved because I either did not use these aspects or could not verify their functionalities. Also, there are some open points where I was too specific in predefining them.

The PR therefore still is a work in progress - after all, the code works on my machine with my customizing, but not on any machine.

OnkelDom commented 2 months ago

@fkonradmain have you any update for this PR? I want to test these on a ubuntu 22.04 minimal at the weekend.

fkonradmain commented 2 months ago

Hi,

Unfortunately, I have been busy lately. I'll see on thursday if I can put up a useable PR.