Submission for assignment 3

[lenhuthao0777]

Link demo: https://df-frontend-2023-zo2c.vercel.app/

[chinhld12]

Hi @lenhuthao0777,

Requirements

• [x] All core functionalities present
• [ ] Proper TypeScript implementation
• [x] No eslint warnings & errors
• [ ] Husky & lint-staged integration

Final Result: ❌ failed

Feedback

1. Should block the user to select the placeholder option

   

2. As you implement the Typescript do not implement any for the type https://github.com/lenhuthao0777/df-frontend-2023/blob/b9f9bd3671022a127daf438007f4f37c66416a0a/assignment-3/src/components/ui/select.tsx#L3-L8 https://github.com/lenhuthao0777/df-frontend-2023/blob/b9f9bd3671022a127daf438007f4f37c66416a0a/assignment-3/src/components/ui/select.tsx#L30-L31 https://github.com/lenhuthao0777/df-frontend-2023/blob/b9f9bd3671022a127daf438007f4f37c66416a0a/assignment-3/src/pages/book/search.tsx#L14-L15 https://github.com/lenhuthao0777/df-frontend-2023/blob/b9f9bd3671022a127daf438007f4f37c66416a0a/assignment-3/src/pages/book/search.tsx#L9-L10

For reusable Pagination, you can refer to the usage with Generics instead of defining data with type any https://github.com/lenhuthao0777/df-frontend-2023/blob/b9f9bd3671022a127daf438007f4f37c66416a0a/assignment-3/src/hooks/use-pagination.ts#L2-L3

In some places, you've not added the type https://github.com/lenhuthao0777/df-frontend-2023/blob/b9f9bd3671022a127daf438007f4f37c66416a0a/assignment-3/src/components/ui/select.tsx#L16-L17 https://github.com/lenhuthao0777/df-frontend-2023/blob/b9f9bd3671022a127daf438007f4f37c66416a0a/assignment-3/src/pages/book/book-table.tsx#L37-L38 ....

You can try setting this config to true to see how many places in your code base are using implicit any: https://github.com/lenhuthao0777/df-frontend-2023/blob/b9f9bd3671022a127daf438007f4f37c66416a0a/assignment-3/tsconfig.json#L15-L16