search

lenis0012 / NPCFactory

NPC Library for CraftBukkit mod.
MIT License
24 stars 19 forks source link

Fix issue crashing with sending packets to a null player #17

Closed ghost closed 9 years ago

ghost commented 9 years ago

Since it try's using the normal methods you must replace it with a null method

DarkShimy00 commented 9 years ago

How can this bug be reproduced/when did it happen?

I use Spigot and I have no issues.

lenis0012 commented 9 years ago

I think he means that it does not work without spigot? This commit would probably break spigot support tho, if it indeed has more methods in craftbukkit.

But i dont believe so, as this is built of craftbukkit and the build would fail.

DarkShimy00 commented 9 years ago

Yes, maybe. But I can't see the purpose of these commits.

ghost commented 9 years ago

Since it trys using the normal methods when the player isent real and it trys sending packets to it then the server crashes so you need to replace all packet methods with null method

lenis0012 commented 9 years ago

What does this have to do with incompatibility with spigot and craftbukit?

ghost commented 9 years ago

The packets are being sent to a invalid player so the server crashes.

lenis0012 commented 9 years ago

@stopbox I still dont get the title

ghost commented 9 years ago

@lenis0012 i renamed it there...

DarkShimy00 commented 9 years ago

@stopbox How can you reproduce this bug? I don't understand why the plugin would send packets to a null player.

ghost commented 9 years ago

@DarkShimy00 the Default PlayerConnection causes the crash

lenis0012 commented 9 years ago

@stopbox I get what you mean yes. Ill have to test this tho

ghost commented 9 years ago

This is no longer useful closing.