Step 6 - Relating two variables

[github-learning-lab[bot]]

Step 6: Relating two variables

In step 4, you wrote a query that finds the definitions of functions named memcpy in the codebase. Now, we want to find all the calls to memcpy in the codebase.

One way to do this is to declare two variables: one to represent functions, and one to represent function calls. Then you will have to create a relationship between these variables in the where section, so that they are restricted to only functions that are named memcpy, and calls to exactly those functions.

[github-learning-lab[bot]]

:keyboard: Activity: Find all the calls to memcpy

1. Edit the file 6_memcpy_calls.ql
2. Use the auto-completion feature to find the class that represents function calls, and declare a variable that belongs to this class.
3. Use auto-completion again on your function call variable to guess the predicate that tells us the target function that is being called.
4. Combine this with your logic from step 4 to make sure the target function is named memcpy.
5. Once you're happy with the results, submit your solution.

Tip: You can have a look at this C++ example in the CodeQL cookbook. Note that your query will be simpler as you won't need to consider the declaringType.

Note: Once you have good results, you can try to make your query more compact by omitting the intermediate Function variable. The 2 queries below are equivalent:

from Class1 c1, Class2 c2
where
  c1.getClass2() = c2 and
  c2.getProp() = "something"
select c1

from Class1 c1
where c1.getClass2().getProp() = "something"
select c1

[github-learning-lab[bot]]

Ooops! The query you submitted in 9b702787f1570b14adc79ad5e6d3e4a875112e38 didn't find the right results. Please take a look at the comment and try again.

To submit a new iteration of your query, you just have to push a new commit to the same branch (main or the PR branch).

[github-learning-lab[bot]]

Congratulations, looks like the query you introduced in 612cbf104500ea2a41c2e8b8ed9544b67e0fc63e finds the correct results!

If you created a pull request, merge it.

Let's continue to the next step.