lenmus / lomse

A C++ library for rendering, editing and playing back music scores.
MIT License
120 stars 28 forks source link

MusicXML: Import <defaults> element #322

Closed cecilios closed 3 years ago

cecilios commented 3 years ago

This PR imports the <defaults> element, with the exception of the <concert-score> element, useless for now, and the <appearance> values, also useless for now and because importing them will require to make engraving options not constant and this is not an urgent change.

The main achievements with this PR are:

Imported scores should now properly display lyric lines when using non-Latin languages. For instance, test score Echigo-Jishi.musicxml.txt from MusicXML test set:

Lomse, before this PR:

image

Lomse, after this PR:

image

This PR also:

//After this PR: //odd pages LUnits page_left_margin_odd() const; LUnits page_right_margin_odd() const; LUnits page_top_margin_odd() const; LUnits page_bottom_margin_odd() const; void set_page_left_margin_odd(LUnits value); void set_page_right_margin_odd(LUnits value); void set_page_top_margin_odd(LUnits value); void set_page_bottom_margin_odd(LUnits value); //even pages LUnits page_left_margin_even() const; LUnits page_right_margin_even() const; LUnits page_top_margin_even() const; LUnits page_bottom_margin_even() const; void set_page_left_margin_even(LUnits value); void set_page_right_margin_even(LUnits value); void set_page_top_margin_even(LUnits value); void set_page_bottom_margin_even(LUnits value);



@dmitrio95 Probably you have some MusicXML samples with texts and lyrics in Russian language. If so and it is possible for you, I would appreciate if you could send me a couple of samples, for testing and reference, by PM if you prefer. Thank you!
dmitrio95 commented 3 years ago

Sure, I have sent you some sample scores by e-mail.