lenmus / lomse

A C++ library for rendering, editing and playing back music scores.
MIT License
117 stars 28 forks source link

Fix bug in noterest_collisions_fixer #334

Closed cecilios closed 2 years ago

cecilios commented 2 years ago

Rendering score Can You Feel The Love Tonight-017.musicxml (provided by @hugbug in #223, and available in that issue) I found a rare problem: the score was displayed as a blank page. As the score was rendered without problems after fixing #223, in PR #225, the problem should be related to new code. After some investigation, the problem was in noterest_collisions_fixer, that used a bad parameter for tenths to logical conversion. The problem has been there since noterest_collisions_fixer was added but for scores with just one instrument (e.g. piano) it didn't cause problems.

Also, this PR adds two test scores for pedal marks, for regression tests.