lennart-rth / Live-Earth-Wallpapers

A collection of all earth related space Images in one script to set as your Desktop background.
GNU General Public License v3.0
301 stars 13 forks source link

added astronomy picture of the day as image source #21

Closed fauwara closed 1 year ago

fauwara commented 1 year ago

this PR is for issue #10 I have scraped the image from apod

I have also added different fit options for the image:

fill: (the image will be stretched or squished to fit)

apod-fill

settings:
  width: 1920
  height: 1080
  bg-color: "#000000"

planets:
  apod:
    x: 960
    y: 540
    width: 1920
    height: 1080
    fit: fill

the yml file for "fill" looks something like this

contain: (the image keeps its aspect ratio, but is resized to fit within the given dimension)

apod-contain

settings:
  width: 1920
  height: 1080
  bg-color: "#000000"

planets:
  apod:
    x: 960
    y: 540
    width: 1920
    height: 1080
    fit: contain

the yml file for "contain" looks something like this

cover: (the image keeps its aspect ratio and fills the given dimension. The image will be clipped to fit)

apod-cover

settings:
  width: 1920
  height: 1080
  bg-color: "#000000"

planets:
  apod:
    x: 960
    y: 540
    width: 1920
    height: 1080
    fit: cover

the yml file for "cover" looks something like this

fauwara commented 1 year ago

I'm not sure how to squash and merge is it supposed to be done on my end or yours? also sorry for the messy PR I'm kind of new to this. 😅

lennart-rth commented 1 year ago

Very nice! It's done on my end! In case you are wondering: I will now add this to a new branch, test it on all OS (you never know;) and merge it into main branch. You can read more about the Github flow here: https://docs.github.com/en/get-started/quickstart/github-flow