search

lennyburdette / ember-addon-broccoli-test-helper

Helpers for testing the broccoli build aspects of Ember Addons
Other
1 stars 1 forks source link

Does not support linked ember-cli #6

Open stefanpenner opened 6 years ago

stefanpenner commented 6 years ago

When testing an addon which uses ember-addon-broccoli-test-helper it must also support when ember-cli is symlinked.

Currently that does not work, as this project relies solely on the node resolution algorithm to locate ember-cli. Rather it likely needs to get its direct reference to ember-cli via this.project.require('ember-cli') https://github.com/ember-cli/ember-cli/blob/master/lib/models/project.js#L356-L369.

lennyburdette commented 6 years ago

I don't quite understand this. Is this what you want to support?

cd ~/GitHub/ember-cli
yarn link
cd ~/GitHub/addon-under-test
yarn link ember-cli
yarn test

Wouldn't this work? ~/GitHub/addon-under-test/node_modules/ember-cli would be a symlink, and when we symlink the node_modules directory into the tmp dir, new EmberAddon() should be able to find it. I think?

(Thank you for your help and feedback today, btw!)