Closed Wraanger closed 5 years ago
There's no information in that stack trace that gives me any hint as to what's going on. Can you please send your list of bindings?
Also, please, send any information about when this happens. Is it on login? Is it when any certain thing happens?
Thanks!
Sorry for not replaying sooner, wasa bit out of town.
I got no list of bindings because this mistake pops up at login, list of speels to bind is empty, other lists too. The only one which got any entries is list of items.
пн, 22 окт. 2018 г. в 6:53, lenonk notifications@github.com:
There's no information in that stack trace that gives me any hint as to what's going on. Can you please send your list of bindings?
Also, please, send any information about when this happens. Is it on login? Is it when any certain thing happens?
Thanks!
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lenonk/ElvUI_SpellBinder/issues/3#issuecomment-431733054, or mute the thread https://github.com/notifications/unsubscribe-auth/AACAqJ5Wyq3Psw6E8EvV0pDNwzHOTqyfks5unUEvgaJpZM4XyrGM .
-- Не мы идем по Пути ... но Путь проходит сквозь нас ...
Ok, knowing this happens at login helps. And yes, if it does happen at login, the code to load the list of spells is never going to fire. Could you look through your inventory and bags for anything with an odd name? Basically, anything that has a name that includes anything other than A-Z.
Thanks!
Also, what is your localization? Meaning, what language do you run the game in?
Everything in my bags will be other than A-Z...because my game client is ruRU.
пт, 26 окт. 2018 г. в 22:58, lenonk notifications@github.com:
Also, what is your localization? Meaning, what language do you run the game in?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lenonk/ElvUI_SpellBinder/issues/3#issuecomment-433526002, or mute the thread https://github.com/notifications/unsubscribe-auth/AACAqJ-K9sY3JmQBJFMSxhL1Gu6aULvJks5uo2lpgaJpZM4XyrGM .
-- Не мы идем по Пути ... но Путь проходит сквозь нас ...
That's why I asked the second question. I think we're seeing an issue with localization. I'll have to try to figure it out. No ETA on that since I don't really know where to start. Thanks for reporting this. I'll get it sorted out as soon as possible, though I have no idea how to test it. Would you be interested in testing?
Sure. I can even do a clean install with only Elvui and your plugin to eliminate other possible influences. Also, if you need i can translate to RU.
сб, 27 окт. 2018 г., 3:26 lenonk notifications@github.com:
That's why I asked the second question. I think we're seeing an issue with localization. I'll have to try to figure it out. No ETA on that since I don't really know where to start. Thanks for reporting this. I'll get it sorted out as soon as possible, though I have no idea how to test it. Would you be interested in testing?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lenonk/ElvUI_SpellBinder/issues/3#issuecomment-433575462, or mute the thread https://github.com/notifications/unsubscribe-auth/AACAqEiA45bQ6ukUCrD0AV2BUq52GEm3ks5uo6g2gaJpZM4XyrGM .
I don't think a clean install is necessary. After considering it for a time, I think I'm going to find a russian phrase on the internet and force it in to all the relevant tables and data structures, and work with it from there. If it works with any non-english characters, it should work with all non-english characters, with a few exceptions perhaps. Just testing the final product I think will be sufficient.
Thanks!
You are welcome! Though, something to think on: item list was fine...you used ItemID for that? May be use SpellID? Then there should be no locale issues...
вс, 28 окт. 2018 г., 3:45 lenonk notifications@github.com:
I don't think a clean install is necessary. After considering it for a time, I think I'm going to find a russian phrase on the internet and force it in to all the relevant tables and data structures, and work with it from there. If it works with any non-english characters, it should work with all non-english characters, with a few exceptions perhaps. Just testing the final product I think will be sufficient.
Thanks!
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lenonk/ElvUI_SpellBinder/issues/3#issuecomment-433666993, or mute the thread https://github.com/notifications/unsubscribe-auth/AACAqBGk54N3i7Mc0c7Nt5Poxhv-V1grks5upP4SgaJpZM4XyrGM .
No, the item list is the same as the spell list.
When I have a fix, are you able to clone from github or do I need to build a package for you?
I'll clone.
вс, 28 окт. 2018 г., 22:53 lenonk notifications@github.com:
When I have a fix, are you able to clone from github or do I need to build a package for you?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lenonk/ElvUI_SpellBinder/issues/3#issuecomment-433735897, or mute the thread https://github.com/notifications/unsubscribe-auth/AACAqGMHj5AzV0GtsGV3scTYYvEjtXQAks5upgs-gaJpZM4XyrGM .
I'm having a hard time reproducing this, but I'm still working on it, just FYI.
Ok, so, I think I have a fix. Can you clone and see if it works now? I'm sorry for the delay, btw, it's been a rough couple of weeks. I had a cat die, and my wife had a surgical procedure, and I've been slammed at work, so I've had little time to work on it. Please let me know if it's working now!
Thanks!
I'm also getting this error on login
ElvUI_SpellBinder\Libraries\AceGUI-3.0-SharedMediaWidgets\prototypes.lua:4: unexpected symbol near ']'
New install, no bindings set.
I may have figured it out, it seems that ]===] was repeated on line 4. I am not a coder, but it made sense. Seems to be working fine now. Great addon btw :)
Hmm, the code on line 4 is appropriate. It's a block comment. There are no issues there. Also, something like that should be affecting every person with the addon, not just non-english clients. I wonder if we're seeing a bug in WoW's Lua interpreter that is somehow only manifesting in non-english clients....
Thanks! :)
Could you make like 4 look like the following and see if that fixes your issue?
--@end-debug@--]===]
Thanks!
Line 4 originally appeared as
--@end-debug@--]===] ]===]
I removed the extra and all is well.
Ok...that's just WEIRD. Look at this... https://github.com/lenonk/ElvUI_SpellBinder/blob/master/Libraries/AceGUI-3.0-SharedMediaWidgets/prototypes.lua#L4
Why would your copy look different than what's in the repository?
I had trouble originally downloading the addon thru twitch, kept kicking back an error. I used tukui client to get it later. Maybe I got a ghost :)
I'm going to leave this issue open for now, but the resolution is in the above 5 comments. For posterity, if you're having this issue, please try deleting the addon and reinstalling. If you still have the issue, please let me know.
Strangeness ensues. Updated via Twitch, got errors upon log-in. Just for kicks, I checked the prototypes lua and it was back.
--@end-debug@--]===] ]===]
Deleted the extra ]===] and works just fine. Not sure how the hell it's getting that extra in there from the update though.
That's messed up, and I'm sad that it continues to happen. I've scoured the internet for problems similar to this, and can't seem to find anything. I guess I'll continue to leave this open.
Hmm...I wonder if this is an issue with the packaging script I'm using. When I create a new tag on github, Travis CI gets a notification and automatically packages everything and uploads to curse and WoW Interface. It has to be an issue during packaging. It's the only thing that makes sense.
That being said, I'm using the BigWigs packaging script which thousands of people use...so...still very odd. I'll look into it after the next round of udpates.
I removed the offending line altogether. I hope I don't have to update the SharedMediaWidgets often. In any case, this problem should be solved for good.
Message: ...ElvUI_SpellBinder\Libraries\AceGUI-3.0-SharedMediaWidgets\prototypes.lua:4: unexpected symbol near ']' Time: Mon Oct 22 00:15:49 2018 Count: 1 Stack: ...ElvUI_SpellBinder\Libraries\AceGUI-3.0-SharedMediaWidgets\prototypes.lua:4: unexpected symbol near ']'
Locals:
Message: ...braries\AceGUI-3.0-SharedMediaWidgets\FontWidget.lua:7: Cannot find a library instance of "AceGUISharedMediaWidgets-1.0". Time: Mon Oct 22 00:15:49 2018 Count: 1 Stack: ...braries\AceGUI-3.0-SharedMediaWidgets\FontWidget.lua:7: Cannot find a library instance of "AceGUISharedMediaWidgets-1.0". [C]: in function
error' Interface\AddOns\ElvUI\Libraries\LibStub\LibStub.lua:23: in function
LibStub' ...braries\AceGUI-3.0-SharedMediaWidgets\FontWidget.lua:7: in main chunkLocals: (*temporary) = "Cannot find a library instance of "AceGUISharedMediaWidgets-1.0"."
Message: ...raries\AceGUI-3.0-SharedMediaWidgets\SoundWidget.lua:7: Cannot find a library instance of "AceGUISharedMediaWidgets-1.0". Time: Mon Oct 22 00:15:49 2018 Count: 1 Stack: ...raries\AceGUI-3.0-SharedMediaWidgets\SoundWidget.lua:7: Cannot find a library instance of "AceGUISharedMediaWidgets-1.0". [C]: in function
error' Interface\AddOns\ElvUI\Libraries\LibStub\LibStub.lua:23: in function
LibStub' ...raries\AceGUI-3.0-SharedMediaWidgets\SoundWidget.lua:7: in main chunkLocals: (*temporary) = "Cannot find a library instance of "AceGUISharedMediaWidgets-1.0"."
Message: ...es\AceGUI-3.0-SharedMediaWidgets\StatusbarWidget.lua:7: Cannot find a library instance of "AceGUISharedMediaWidgets-1.0". Time: Mon Oct 22 00:15:49 2018 Count: 1 Stack: ...es\AceGUI-3.0-SharedMediaWidgets\StatusbarWidget.lua:7: Cannot find a library instance of "AceGUISharedMediaWidgets-1.0". [C]: in function
error' Interface\AddOns\ElvUI\Libraries\LibStub\LibStub.lua:23: in function
LibStub' ...es\AceGUI-3.0-SharedMediaWidgets\StatusbarWidget.lua:7: in main chunkLocals: (*temporary) = "Cannot find a library instance of "AceGUISharedMediaWidgets-1.0"."
Message: ...aries\AceGUI-3.0-SharedMediaWidgets\BorderWidget.lua:7: Cannot find a library instance of "AceGUISharedMediaWidgets-1.0". Time: Mon Oct 22 00:15:49 2018 Count: 1 Stack: ...aries\AceGUI-3.0-SharedMediaWidgets\BorderWidget.lua:7: Cannot find a library instance of "AceGUISharedMediaWidgets-1.0". [C]: in function
error' Interface\AddOns\ElvUI\Libraries\LibStub\LibStub.lua:23: in function
LibStub' ...aries\AceGUI-3.0-SharedMediaWidgets\BorderWidget.lua:7: in main chunkLocals: (*temporary) = "Cannot find a library instance of "AceGUISharedMediaWidgets-1.0"."
Message: ...s\AceGUI-3.0-SharedMediaWidgets\BackgroundWidget.lua:7: Cannot find a library instance of "AceGUISharedMediaWidgets-1.0". Time: Mon Oct 22 00:15:49 2018 Count: 1 Stack: ...s\AceGUI-3.0-SharedMediaWidgets\BackgroundWidget.lua:7: Cannot find a library instance of "AceGUISharedMediaWidgets-1.0". [C]: in function
error' Interface\AddOns\ElvUI\Libraries\LibStub\LibStub.lua:23: in function
LibStub' ...s\AceGUI-3.0-SharedMediaWidgets\BackgroundWidget.lua:7: in main chunkLocals: (*temporary) = "Cannot find a library instance of "AceGUISharedMediaWidgets-1.0"."
Message: ...ElvUI_SpellBinder\Libraries\AceGUI-3.0-SharedMediaWidgets\prototypes.lua:4: unexpected symbol near ']' Time: Mon Oct 22 00:15:58 2018 Count: 5
Message: (null) Time: Mon Oct 22 00:15:58 2018 Count: 25