search

lenonk / ElvUI_SpellBinder

Note: I no longer have a WoW acount, and therefore can no longer maintain this addon. If you would like to become the maintainer, be my guest! This is a WoW addon that provides Clique like functionality specifically for ElvUI users. It's still currently Alpha, but most of the functionality is there, and it seems solid. Support for hovercasting to come soon.
Other
0 stars 2 forks source link

No spells in the list #4

Closed viktae closed 5 years ago

viktae commented 5 years ago

No spells in that dropdown list. Monk Mistweaver https://i.imgur.com/EgASRm9.png

lenonk commented 5 years ago

I'm sorry, I don't have a monk to test with. Maybe I can roll on on the PTR and figure this one out. It has to be something simple. I'll update the ticket once I've done that. Thanks!

lenonk commented 5 years ago

Also, please make sure that you're seeing any Lua errors that are occuring. Run /console scriptErrors 1 while in the game, then log in again please.

It's like that you are getting a Lua error and not just seeing it because it's suppressed.

lenonk commented 5 years ago

I beleive this issue is fixed now. I'm pretty sure it was related to running in languages other than english. If you wish, feel free to clone from the repo here and test and let me know how it goes. Otherwise, I'll be putting out a new version as soon as I hear back from my other tester. Assuming it works. ;)

Wraanger commented 5 years ago

Just cloned it and gave it a try. No error at login, but spell lists are empty still.

Question - why no use SpellID? it's locale independent...

чт, 8 нояб. 2018 г. в 0:58, lenonk notifications@github.com:

I beleive this issue is fixed now. I'm pretty sure it was related to running in languages other than english. If you wish, feel free to clone from the repo here and test and let me know how it goes. Otherwise, I'll be putting out a new version as soon as I hear back from my other tester. Assuming it works. ;)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/lenonk/ElvUI_SpellBinder/issues/4#issuecomment-436792882, or mute the thread https://github.com/notifications/unsubscribe-auth/AACAqIdinGDNNaRsxEZtq-FcFpUlvAjZks5us1ePgaJpZM4X8L2L .

-- Не мы идем по Пути ... но Путь проходит сквозь нас ...

lenonk commented 5 years ago

Because item id is impossible to get, as far as I know, without knowing the bag and slot of an item, and I want to support items, and all the data structures should be homogeneous. That being said, the data structures are not the issue. It's something about the way I'm building the configuration structure that is creating a problem for you. The lua error is short circuiting the code and causing it to stop before the lists are being built. The tables that you're referring to with spell names for keys are never seen by the AceGUI library.

lenonk commented 5 years ago

Just to confirm what I think the issue is, if make a new branch with some debugging code, are you willing and able to clone from it and test? If so, can we get some sort of instant communication going? Either facebook messenger, or skype, or google hangouts or something?

We could even use Zoom and you could share you're screen if you comfortable with that.

Wraanger commented 5 years ago

Sure, I'm willing. We can use skype(uzandaf) or Facebook or Discord

пт, 9 нояб. 2018 г., 8:10 lenonk notifications@github.com:

Just to confirm what I think the issue is, if make a new branch with some debugging code, are you willing and able to clone from it and test? If so, can we get some sort of instant communication going? Either facebook messenger, or skype, or google hangouts or something?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lenonk/ElvUI_SpellBinder/issues/4#issuecomment-437252105, or mute the thread https://github.com/notifications/unsubscribe-auth/AACAqMKfBWVCXQXjBqz-Ntyj1ZauI9Atks5utQ5XgaJpZM4X8L2L .

lenonk commented 5 years ago

Excellent. Let me know when you have time to do it and we'll get on it

lenonk commented 5 years ago

Actually, before we do that, can you please try the following for me?

/dump UnitClass("player") Paste the output please

/dump GetSpecializationInfo(GetSpecialization()) Paste the output of that as well.

Thanks!

lenonk commented 5 years ago

Regardless of what the issue was, this should be fixed now, since the method for determining the spell list is now automatic and based on the spell book as opposed to being a static list. Closing