search

lenosisnickerboa / csgosl

A CSGO server launcher, one-click install & run
GNU General Public License v3.0
377 stars 39 forks source link

Adding a new tab with the most used commands would be great:D #73

Closed CJNiiva closed 7 years ago

CJNiiva commented 7 years ago

having a tab with the most used commands would be great:D like sv_enablebunnyhop and sv_autobunnyhop (I'm sure thats the command, but I always use the autothing in the console for these 2) also sv_airaccelerate etc, would be great:D

CJNiiva commented 7 years ago

you could also have a session here on github where people could add commands to that tab so that the most used commands for everyone is there:D

lenosisnickerboa commented 7 years ago

Not sure I completely understand what you want. Do you mean something like string entries where you can add any command and value or do you mean adding most used options like all other csgosl options, i.e. that I add buttons, checkboxes, number entries ... depending on the option you want to control?

The first alternative could be located on a separate tab with just a number of empty string entries. If you mean the second alternative that probably would mean adding more options to the already existing tabs, right? Since I have tried to gather options into related groups like Server, Steam, Sourcemod, ...

So the sv_enablebunnyhop and sv_autobunnyhop could be two checkboxes on the Run tab and sv_airaccelerate could be a number entry on the Run tab.

So, please explain some more what you want and I'll certainly consider it.

Also, do you know a good source describing all commands? There's e.g. the one I used for the all command tabs All commands but it doesn't seem to be updated, e.g. doesn't contain the one's you're suggesting,

Manni79 commented 7 years ago

I think the Issue Author just wants more cvars in the existing tabs.

But I think the idea of being able to customize the tabs is much better. I also miss cvars on the "Run" tab and also on the detailed tabs with cvars to each gaming mode. I want to save in csgosl more and different cvars for different game modes.

I think a solution with "_custom_cvar"-cfg-files would be nice for each tab. The files should exist in your csgosl folder for every tab like "run", "all modes" and for each gaming mode. Then everybody can go into these files and add own cvars. When someone edit a "_custom_cvar"-cfg files and add cvars, you should by starting csgosl read all "*_custom_cvar" cfg files and show in every tab the cvars a user has added to these files. Plus, the user should be able to see and edit the custom cvars in csgosl gui interface, ones new custom cvars are added to these files by the user.

In the tabs "run", "all modes" and every gaming mod, you can add (on the bottom) a big line as separator, with a big title "Custom Cvars". And as subtitle: "All following cvars are customized CFGs" or better for every sheet you can write a subtitle, which point directly to the custom file wich is used. Subtitle example for Custom Cvars in "all modes tab" should be: "All following cvars are out of custom file: /cfg/gamemode_all_Custom_cvars.cfg"

You only have to show the user the separator and the subtitle, if he had entered cvars in the corresponding custom_cvar file. If a user has no customization, you don't need to show separator and subtitle on the tabs.

Show the Info only, where the user has added custom cvars in the new custom_cvar cfg files.

Of course you can add more functionality to this. You can have a "New" button in the "custom cvar" section of each tab, to add new cvars. If you use the "new" button and add the cvar, the cvar should be written to the corresponding custom-cvar-cfg. Also a "delete" button make sense. But I think you don't need the buttons, every user who want to make customizations like this, could be as experienced, to do it with manual file editing. For me, it would be very nice and good enough.

On every tab, which supports adding cvar customization, you should add the customize section separator on the bottom of the tab content site. Then followed by the subtitle. Then followed by the custom cvars out of the corresponding custom-cvar-files.

I think that would be great, and it is also a solution for the Author of this issue. Because then, he can go to the files vor customized cvars for "all gamodes" or for the "run tabs" and then add his missed cvars " sv_enablebunnyhop and sv_autobunnyhop" there. And ones he add theses cvars in the custom-cvar-cfgs for "run" tab and "all gamemode" tab (and re-starting csgosl) he can administrate, see and change these cvars settings right out of csgosl.

I would really love to see such a feature in csgosl. I think many people have more cvars they want to add to the the tabs. Same for me. And then everybody can add cvars to tabs he want.

The cvars in the custom files should be executed last. If someone add cvars in a custom files, which already exist it in corresponding original file, the custom cvar setting should be the active one.

Best regards Manni

lenosisnickerboa commented 7 years ago

Thanks @CJNiiva and @Manni79 for a lot of good input. Yes, some kind of user defined cvars would be nice and I've also considered it. Some thoughts on the subject...

First of all, adding a user defined option also means defining a type for that option. That type is used to select how to represent that option, e.g. by a toggle button (on/off), a dropdown listbox (e.g. select one of many gamemode types), an integer number (e.g. number of players) or simply a string (e.g. the server name). Most options also have a default value. Furthermore, some options are command line options, others go into server.cfg, and still others go into gamemode specific cfg files. csgosl is intended to hide all this from the non experienced end user to allow "anyone" to start a csgo server with some sane defaults and easy tweaking of the most common options.

Having said all that, to allow user defined options, the user would have to be able to specify option name, type, default value, where the option is used (command line, which config file, ...). This could of course be done with a "New" button where the user has to specify all this.

Configuration files could of course also be a way to do it, but then we're pretty much back where I started with csgosl, wanting to avoid people having to find and edit config files.

Another aspect is getting csgosl to provide the "right" options, i.e. the ones most people are interested in. By adding user defined options each user can add their own options but csgosl will not be improved with these wanted options which would benefit all users.

Well well, of course csgosl could support all of the above. I'll have to think some more about this. Meanwhile I will add an issue for wanted options in csgosl.

And keep the ideas coming :)

Manni79 commented 7 years ago

For me, I would first assign only the "normal" cvars which a player can also enter in CS console when server is running. So all mp*, sv* and other settings, which could be on the "all modes" and on the dedicated tabs for each game mode.

And for me, the customized section in first shot with simple text, should not need special "types". Everything can be type string, for the option. In string, everybody can simply enter a "string" or also a number "2". It should simply work, also without using GUI.

When the user add some cvars to the new files "/cfg/gamemode_cacual_custom_cvars.cfg", or "/cfg/gamemode_all_custom_cvars.cfg", ... like ... sv_enablebunnyhop "1" sv_autobunnyhop 2 ... then csgosl should simply read it, order it, correct the format (e.g. double blanks, set value in "" etc) and show it on the new "custom" section on the buttom of both corresponding tabs.

Of course you can make in the feature much more improvement:

Another aspect is getting csgosl to provide the "right" options, i.e. the ones most people are interested in.

Yes, in the 2nd shot with more improvements, you can add the new button. In the "New" Button you can simply implement all that to extend the usability. New Button can support, showing often used cvars, explanation of them, default value showing, correct type, validation check, a check if the cvar can be used in the corresponding tab. You can also implement a "edit" button wich support all of this features. But for the data saving, I see very simple flat text files like normal cvar-cfgs, which everybody can also simply edit on text level and re-start csgoesl.

And in the first shot, for me, it would be fit without check and without validations and even without buttons. Simply visualizing in csgosl and make "editable and saveable" through gui, ones entered in the text file.

lenosisnickerboa commented 7 years ago

So, I just released 1.5. Have a go and see what you think. It is somewhat described here.

Manni79 commented 7 years ago

I tried now, but it's not working for me. I tried on Classic_Casual, clicked on new cvar

... entered:

Nothing happens. I am not seeing mp_autoteambalance in the list then.

Thanks and best regards Manni

Manni79 commented 7 years ago

btw, would be nice when you could to a alphabetic sort on all Tabs. It's a bit disordered at the moment. :-)

Manni79 commented 7 years ago

Perhaps I have missed that a restart of csgosl is required? I started after hours again, and now i see my custom cvar.

lenosisnickerboa commented 7 years ago

Yup, that's it.

Den 16 apr. 2017 2:18 fm skrev "Manni79" notifications@github.com:

Perhaps I have missed that a restart of csgosl is required? I started after hours again, and now i see my custom cvar.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lenosisnickerboa/csgosl/issues/73#issuecomment-294325410, or mute the thread https://github.com/notifications/unsubscribe-auth/AQGy9qchU6NwR617PKlwVjllgNLNVt01ks5rwV4ngaJpZM4MYELB .

Manni79 commented 7 years ago

It's not working for mp_autoteambalance and mp_limitteams. Bit I can change it with rcon when I am on the Server. Anything Special with these?

CJNiiva commented 7 years ago

If its on the list I'm guessing its a matter of what is executed first, my guess is the top to bottom

Sendt fra min iPhone

Den 16. apr. 2017 kl. 22.46 skrev Manni79 notifications@github.com<mailto:notifications@github.com>:

It's not working for mp_autoteambalance and mp_limitteams. Bit I can change it with rcon when I am on the Server. Anything Special with these?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/lenosisnickerboa/csgosl/issues/73#issuecomment-294373329, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ASeeLx1zlVeFWfcdK1JWeILCtvHyv71bks5rwn4QgaJpZM4MYELB.

Manni79 commented 7 years ago

Perhaps I waswrong, and it is not working at all for me, i am not sure for now. I have to test a bit more. Or perhaps it is also influenced by my other Problem of starting on command line by myself. Problem of other thread.

Manni79 commented 7 years ago

It's not working and I took a look in CSGO Folder and I don't understand how it should work. For normal changes a user made in csgosl I think you write all settings in a _settings file. On CSGO start, the game read also the _settings files and and activate your csgosl settings.

But how do you think the "custom" cvars were read by the game on start? I see, you write all custom cvars in a _server.custom-file. But I don't think this will be read by the game on start. In the _server.custom files are also much more data stored as simple cvars settings. Description and Default values are also stored here.

So how do you think the custom cvars were activated on game start? (For my opnion, you have to write active custom cvar settings also to *_server-files.)

Perhaps I miss something. :-(

lenosisnickerboa commented 7 years ago

Sorry, missed this email. Can you explain what the problem is? I don't understand. A concrete example of something you think doesn't work may help.

On Thu, Apr 20, 2017 at 10:38 PM, Manni79 notifications@github.com wrote:

It's not working and I took a look in CSGO Folder and I don't understand how it should work. For normal changes a user made in csgosl I think you write all settings in a _settings file. On CSGO start, the game ready also the _settings files and and activate your csgosl settings.

But how do you think the "custom" cvars were read by the game on start? I see, you write all custom cvars in a *custom file. But I don't think this will be read be the game on start. So how do you think the custom cvars were activated on game start?

Perhaps I miss something. :-(

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lenosisnickerboa/csgosl/issues/73#issuecomment-295901036, or mute the thread https://github.com/notifications/unsubscribe-auth/AQGy9kxqFMX9_zyc1TrVcR80rVzDbQ0Iks5rx8JUgaJpZM4MYELB .

lenosisnickerboa commented 7 years ago

Closing, no answer. Please reopen if still an issue.