lenovo / gplcc

1 stars 0 forks source link

Current kernel sources for Lenovo P11 (TB-J606F, TB-J606L) #1

Open maciek134 opened 2 years ago

maciek134 commented 2 years ago

Hello,

The kernel sources you (Lenovo) have posted in your support portal (https://support.lenovo.com/us/en/solutions/ht511330-lenovo-open-source-portal) for the P11 tablet are outdated (kernel version in the archive: 4.19.95, kernel version on device: 4.19.157, the device won't boot with the kernel from the archive).

This seems to be the most appropriate way of contacting you about this, since support already told me to "factory reset my device or send it for repairs" when I tried to ask about this using the form on your website (I couldn't find any e-mail addresses on said website as well).

konradybcio commented 2 years ago

Hi, please update the open source code drop for the Tab P11 (J606F) to match the latest software. The latest one available is from early 2021:

image

Today's July 10th 2022, that means it has not been updated in over a year.

Failing to publish the source code is a clear GPL violation, which means you are selling stolen software (Linux kernel and Qualcomm's GPL2 components) and refusing to fix it. I wrote a tweet 3 months ago, which led me to a series of messages with your customer support.

image

image

image

This is truly unacceptable. You can't just say "oh it will be available eventually". No. You should have published it at the same time as you pushed the OTA update. Or at least within an acceptable timeframe - if it took you less than 30 days, nobody would have complained.

Please fix this, I am truly disappointed both as a developer and a customer.

adazem009 commented 2 years ago

Hi, please update the open source code drop for the Tab P11 (J606F) to match the latest software. The latest one available is from early 2021:

image

Today's July 10th 2022, that means it has not been updated in over a year.

Failing to publish the source code is a clear GPL violation, which means you are selling stolen software (Linux kernel and Qualcomm's GPL2 components) and refusing to fix it. I wrote a tweet 3 months ago, which led me to a series of messages with your customer support.

This is truly unacceptable. You can't just say "oh it will be available eventually". No. You should have published it at the same time as you pushed the OTA update. Or at least within an acceptable timeframe - if it took you less than 30 days, nobody would have complained.

Please fix this, I am truly disappointed both as a developer and a customer.

Hi, take a look at my fork of your repository - lineage-18.1-experimental branch at https://github.com/adazem009/kernel_lenovo_bengal. I tried to merge it with CAF tag LA.UM.9.15.1.r1-07100-KAMORTA.0, which Lenovo probably used in the latest release (in July 2022). It seems to boot, but all I can get in Android is a black screen and a kernel panic after some time. Maybe I could have made mistakes when I was fixing the merge conflicts.

adazem009 commented 2 years ago

I have some screenshots of my conversation with Lenovo support. I really think we need to contact someone else, because the support on Twitter doesn't have access to anything...

pic1 "we have submitted your feedback to the appropriate team" I don't believe they even did this...

pic2

And when I asked again after a few weeks... pic3 "Apologies, we don't have any source code to provide." Well, you're obligated to provide it according to GPLv2...

thefat32 commented 2 years ago

We could try contact https://gpl-violations.org/ if Lenovo does not respond to our requests

adazem009 commented 2 years ago

Hi, please update the open source code drop for the Tab P11 (J606F) to match the latest software. The latest one available is from early 2021: image Today's July 10th 2022, that means it has not been updated in over a year. Failing to publish the source code is a clear GPL violation, which means you are selling stolen software (Linux kernel and Qualcomm's GPL2 components) and refusing to fix it. I wrote a tweet 3 months ago, which led me to a series of messages with your customer support. This is truly unacceptable. You can't just say "oh it will be available eventually". No. You should have published it at the same time as you pushed the OTA update. Or at least within an acceptable timeframe - if it took you less than 30 days, nobody would have complained. Please fix this, I am truly disappointed both as a developer and a customer.

Hi, take a look at my fork of your repository - lineage-18.1-experimental branch at https://github.com/adazem009/kernel_lenovo_bengal. I tried to merge it with CAF tag LA.UM.9.15.1.r1-07100-KAMORTA.0, which Lenovo probably used in the latest release (in July 2022). It seems to boot, but all I can get in Android is a black screen and a kernel panic after some time. Maybe I could have made mistakes when I was fixing the merge conflicts.

Can you dump the kernel logs so I can try to help?

Maybe, but I have to enable pstore first, because it panics immediately when I boot it.

maciek134 commented 2 years ago

Can you stop hijacking this issue with barely-related discussion?

While your attempts to recreate a working kernel are interesting, it shouldn't be needed - Lenovo should have released the sources and this is what the issue is about.

On Sun, Oct 2, 2022, 5:03 PM rsbotting123 @.***> wrote:

Does the device support https://wiki.postmarketos.org/wiki/Serial_debugging ?

— Reply to this email directly, view it on GitHub https://github.com/lenovo/gplcc/issues/1#issuecomment-1264664236, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIX3RKUEVMYNRTIPDSAES3WBGP5BANCNFSM5T7RBPEA . You are receiving this because you authored the thread.Message ID: @.***>

maciek134 commented 2 years ago

There was no anger in my message and I have no idea where I have not "talked properly". I just asked you to stop the discussion that doesn't bring anything to the topic (Lenovo releasing kernel sources), because excessive off-topic can be a reason for closing the issue.

If you think a personal jab is an appropriate response, maybe take a step back and re-read the Community Guidelines.

zhsloe commented 1 year ago

This issue is still relevant as Lenovo didn't do a damn thing to release updated sources.

LynxLyon1 commented 1 year ago

Has anyone updated to android 12 using this file from lenovo's website?

11/07/2022

Open Source Code for Lenovo Tab P11 Plus (Lenovo TB-J616F)

https://support.lenovo.com/us/en/solutions/ht511330-lenovo-open-source-portal

maciek134 commented 1 year ago

@LynxLyon1 this issue is about J606, that's a completely different device for which Lenovo still hasn't uploaded updated kernel sources.

zhsloe commented 1 year ago

@LynxLyon1 this issue is about J606, that's a completely different device for which Lenovo still hasn't uploaded updated kernel sources.

J616F also hasn't got sources for the actual update... but it's not as bad as with the J606, so much is true. I tried to contact Lenovo support on Twitter and haven't got any answer yet. May be sueing Lenovo or contacting organisations like https://gpl-violations.org/ is actually the only way to go? They really don't seem to care about GPL terms and about their tech savvy customers as well...

maciek134 commented 1 year ago

https://gpl-violations.org/ might actually be the only way to go at this point, they just don't care until an actual lawsuit happens

zhsloe commented 1 year ago

https://gpl-violations.org/ might actually be the only way to go at this point, they just don't care until an actual lawsuit happens

I wrote them an email to them two weeks ago and still haven't got any answer... maybe when more ppl write to them about it it'll get their attention?

maciek134 commented 1 year ago

No, if you sent the email to the correct address (license-violation@gpl-violations.org) then more people writing will just give them more work. We already made the mistake of publicly shaming Lenovo about this, I wasn't aware of the violation FAQ there.

zhsloe commented 1 year ago

No, if you sent the email to the correct address (license-violation@gpl-violations.org) then more people writing will just give them more work. We already made the mistake of publicly shaming Lenovo about this, I wasn't aware of the violation FAQ there.

Why do you think public shaming was a mistake? I think it is still too little shaming, the f*ckers should know their place and be aware that GPL violation is something that the Internet is never going to forgive you.

maciek134 commented 1 year ago

The FAQ explains it pretty well why public shaming is not the best idea. I agree with the sentiment, but we might have made it harder for the gpl-violations people

zhsloe commented 1 year ago

The FAQ explains it pretty well why public shaming is not the best idea. I agree with the sentiment, but we might have made it harder for the gpl-violations people

I see, I skipped that point in the FAQ at first — and in a way it does make sense. Still, I personally think that Lenovo fully deserves the shaming — for me it's personal because Lenovo didn't give me any answer on at least two different communication channels where their support is supposed to be active — namely in their support subred and per DM to their official Twitter account. It is just bad customer relations and they must be shamed for it IMHO.

lpicchi commented 1 year ago

@zhsloe did you get any response from gpl-violations.org ?

zhsloe commented 1 year ago

@zhsloe did you get any response from gpl-violations.org ?

No, still no answer...

predefine commented 11 months ago

No, still no answer...

https://www.gnu.org/licenses/gpl-violation.html

mispp commented 9 months ago

@zhsloe Still nothing?

@maciek134 Since its almost a year that passed, another email wouldn't hurt since we definitely didn't overload them with emails.

adazem009 commented 2 months ago

For the time being, you can use this kernel source: https://github.com/adazem009/kernel_lenovo_tbj606 (use vendor/TBJ606_defconfig) It has the new touch panel working + wlan and audio drivers built-in. Please note that it can be only used on the Android 10 firmware. If you have newer fw, you'll have to downgrade to boot it.

I tried to contact Lenovo a few more times, but it isn't going to work. Since we now have a working kernel, I can still try to rebase it for the Android 11 firmware, but I don't know whether it'll work or not. I'll post updates here in case it works...

PS: Does anyone have official Android 12 on the device? Lenovo website says only 11 was planned.

adazem009 commented 1 month ago

Good news, I've managed to rebase the kernel for the Android 11 firmware and everything works fine. Well, except DT2W, but I'll quickly fix that soon... (use the lineage-18.1 branch) I can say that the kernel source Lenovo published was almost complete, only the Novatek touch panel driver was missing which I was able to find in a similar device (TB128FU).

@maciek134 Now that we have a complete kernel source for the latest firmware, can this issue be closed? I agree that Lenovo should've published it after any change they made to it, but the problem of not having a working source is solved.

As a proof, here's a picture of the tablet running official A11 with my kernel that I've just compiled:

IMG_20240813_121901_1

lpicchi commented 1 month ago

Amazing work @adazem009 thank you!

maciek134 commented 1 month ago

@adazem009 great work! I'm not closing the issue though, not until Lenovo stops violating the license as they still didn't release the sources themselves.

lpicchi commented 1 month ago

@maciek134 totally agree with you👍🏼

All the effort and time @adazem009 put on this could have been used for porting a custom ROM or kernel optimization for our device instead of completing missing pieces in Lenovo's faulty kernel source. This is a clear statement of their lack of care about the community of developers in Android's scene.