lenovo / pylxca

PyLXCA is Python based interface for Lenovo xClarity Administrator APIs.
Apache License 2.0
14 stars 11 forks source link

Make whole pylxca code in accordance with PEP8 style guide by using pylint #1

Open walteraa opened 6 years ago

walteraa commented 6 years ago

When running Pylint, for example, in the file pylxca/lxca_cmd.py, I got the following report summary:

------------------------------------
Your code has been rated at -1.95/10

It occurs because some style recommendations aren't followed, for example:

I changed the class name in line 285 from fans to Fan and I ran the pylint again, getting the following report:

--------------------------------------------------------------------
Your code has been rated at -1.82/10 (previous run: -1.95/10, +0.13)

Increasing 0.13% the code quality. It happened because class name should have the first line in upper case and shouldn't be in plural, only collections should be plural, even it referring to a class which has a list command, which the recommendation is use something like that:

pylxca fan list or pylxca fan get ID

rodneyhbrown7 commented 6 years ago

Thanks Walter.