fix: OAuth2 client custom scheme redirect URI - Githubissues

lenra-io / server

GNU Affero General Public License v3.0

6 stars 0 forks source link

fix: OAuth2 client custom scheme redirect URI #521

Closed taorepoara closed 6 months ago

taorepoara commented 6 months ago

For Android and iOS clients

About this PR

We can't create OAuth2 client with a custom scheme in the redirect URI (ex: io.lenra.app:/), but it's needed for Android ans iOS applications.

This PR fixes it.

Technical highlight/advice

Just changed the corresponding Regex.

How to test my changes

start the Docker Compose elements: docker-compose up -d
create the backoffice OAuth2 client (see docs/oauth-testing.md): mix create_oauth2_client backoffice
start the backoffice
create an app
create a OAuth2 client for this app in the backoffice with this value in redirect URI: io.lenra.app:/

Checklist

[x] I didn't over-scope my PR
[x] My PR title matches the commit convention
[x] I did not include breaking changes
[x] I made my own code-review before requesting one

I included unit tests that cover my changes

[x] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

I added/updated the documentation about my changes

[ ] 📜 README.md
[ ] 📕 docs/*.md
[ ] 📓 docs.lenra.io
[x] 🙅 no documentation needed

taorepoara commented 6 months ago

:tada: This PR is included in version 1.0.4 :tada:

The release is available on:

GitHub release
v1.0.4

Your semantic-release bot :package::rocket: