fix: App Adapter Guard - Githubissues

lenra-io / server

GNU Affero General Public License v3.0

6 stars 0 forks source link

fix: App Adapter Guard #565

Closed jonas-martinez closed 3 months ago

jonas-martinez commented 3 months ago

About this PR

There was an issue with credo since the last commit on the "main" branch. It did not run the Elixir CI so we did not see this error.

I just added a pattern match case to check for user == nil. Now credo does not report the refactoring opportunity.

Checklist

[x] I didn't over-scope my PR
[x] My PR title matches the commit convention
[x] I did not include breaking changes
[x] I made my own code-review before requesting one

I included unit tests that cover my changes

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

I added/updated the documentation about my changes

[ ] 📜 README.md
[ ] 📕 docs/*.md
[ ] 📓 docs.lenra.io
[x] 🙅 no documentation needed

taorepoara commented 3 months ago

:tada: This PR is included in version 1.5.4 :tada:

The release is available on:

GitHub release
v1.5.4

Your semantic-release bot :package::rocket: