search

lens / lens-aeson

Traversals and Prisms for Data.Aeson
MIT License
51 stars 18 forks source link

Support aeson-2.0.0.0 #37

Closed phadej closed 3 years ago

phadej commented 3 years ago

https://github.com/phadej/aeson-optics/commit/ff31ca0578482df11002f0cde974ff51b8559e1c is what I did for aeson-optics

RyanGlScott commented 3 years ago

Thanks for the heads-up. I do wonder _Object should eventually focus on a KeyMap rather than a HashMap (see #38), but it's probably too early to think about that. Until then, I'll prepare a PR based off of your aeson-optics patch.

phadej commented 3 years ago

My reasoning was to not change any types short term, and do a breaking change release of aeson-optics supporting only aeson >=2 with changed _Object etc type later.

RyanGlScott commented 3 years ago

That sounds reasonable to me. If you don't mind, please shout on #38 when you make (or are about to make) such changes on aeson-optics' side—I can make corresponding changes on the lens-aeson side at the same time.

RyanGlScott commented 3 years ago

See #39 for a fix.

RyanGlScott commented 3 years ago

I've uploaded lens-aeson-1.1.2 to Hackage with the changes in #39.