search

lensapp / lens

Lens - The way the world runs Kubernetes
https://k8slens.dev/
MIT License
22.52k stars 1.47k forks source link

Logs on windows "blink" and scrolls to bottom #3517

Open tylermichael opened 3 years ago

tylermichael commented 3 years ago

Describe the bug I'm not sure the best way to describe this so I've included a video. When I open the logs of a pod, the window jumps around a lot. Scrolling up, seems to make the logs refresh or something, which then causes the window to scroll all the way to the bottom.

All of my coworkers on Windows have complained about this as well. We don't share a base windows image or anything like that either.

To Reproduce On windows, go to a pod, show it's logs and start to scroll up.

Expected behavior The log window to never jump around.

Screenshots

https://user-images.githubusercontent.com/4096772/127032554-7844599b-a757-4637-9196-eb108348bc56.mp4

Environment:

destumme commented 3 years ago

This also occurs in the MacOS application. It makes that view almost useless.

Lens: 5.1.3-latest.20210722.1
Electron: 9.4.4
Chrome: 83.0.4103.122
Node: 12.14.1
erharb commented 3 years ago

Still occurring on latest version on Windows:

Lens: 5.2.5-latest.20211001.2 Electron: 12.2.1 Chrome: 89.0.4389.128 Node: 14.16.0

Also tried installing an older version, also happens on 5.0.2-latest.20210705.2, and v4.2.5

aperullo commented 2 years ago

Also seeing this. Makes it pretty hard to use. Anyone know of an older version that works?

Lens: 5.2.4-latest.20210923.1 Electron 12.07.1

SimonePedersen commented 2 years ago

Gah this issue has been driving me mental, it started a few months ago and makes Lens pretty much unusable for checking logs.

Lens: 4.1.3 Electron: 9.4.0 Chrome: 83.0.4103.122 Node: 12.14.1

tylermichael commented 2 years ago

I looked into this issue and it doesn't happen nearly as much when running OpenLens locally in dev mode for me.

When it did happen though, it seems like the pod object somehow changes, which then cascades down to the log store reset function.

I did check and nothing on the pod object actually changes except for things like the patch and update functions, which to me means that it is a new instance and mobx interprets it as a change which then cascades to the other stores like logs.