KAFKA_REST problem EXPERIMENTAL_PROXY_URL

lensesio / kafka-topics-ui

Web Tool for Kafka Topics |

https://lenses.io

877 stars 148 forks source link

KAFKA_REST problem EXPERIMENTAL_PROXY_URL #160

Open fssrepository opened 4 years ago

fssrepository commented 4 years ago

I'm using nginx and had put kafka-topics-ui under subPath.

I'm not sure what you are using, but it could be far easier to introduce $KAFKA_REST in the run.sh instead of $EXPERIMENTAL_PROXY_URL pls. Now I'm overriding your whole run.sh!

It's a bad coding practice to use the same $KAFKA_REST_PROXY_URL first with a configured value and override in the script later on.

mariosant commented 4 years ago

Hey @fssrepository, thanks for the suggestion. I am not entirely sure of what you are suggesting there. Would you like to submit a PR for further iteration?