fix: prevent creation of schemas in readonly mode

fstaudt commented 5 years ago

This pull request allows to fix 2 issues linked to readonly feature:

creation of schemas was still allowed in readonly mode (button shown + validation not blocked in case of direct access to /schema/new)
readonly mode not correctly set in env.js by run.sh script in docker (due to typo in READONLY_SETTING variable)

This change is

fstaudt commented 5 years ago

@jglambed

can you check this PR ? It is a correction of my previous PR.

Kr, François

jglambed commented 5 years ago

Thanks @fstaudt for the fix!

fstaudt commented 5 years ago

@jglambed

I noticed a strange behavior with the latest docker image for schema-registry-ui on dockerhub.

The dockerhub documentation and run.sh script included in the docker image comes from master branch. However, the Angular application still contains the code of release 0.9.5.

I believe this is linked to the DockerFile that still specifies 0.9.5 for the angular package.

As a result, the documentation on dockerhub is not inline with the latest docker image. The readonly mode is referenced in documentation but is ignored by the Angular application.

Do you plan to release 0.9.6 soon ?

lensesio / schema-registry-ui

fix: prevent creation of schemas in readonly mode #89