search

lensvol / pybetter

Tool for fixing trivial problems with your code.
MIT License
62 stars 6 forks source link

Can pybetter support click 8.x ? #128

Closed sreerajkksd closed 1 year ago

sreerajkksd commented 2 years ago

Looks like there is a hard dependency on click 7.x on the installation docs. Can we make it support click 8 as well ? (PS: I'm almost sure that it works, so we might need to make it explicit on the configs. )

lensvol commented 2 years ago

I think it can be done. Is there any specific reason for the upgrade to happen?

sreerajkksd commented 2 years ago

Nothing specific!

we use a virtual environment for our tool that need both click and pybetter. Installing pybetter downgraded click and that is not what we want. I could fix it by reinstalling click==8.0.3 but just wanted to point this out.

paw-lu commented 2 years ago

Just to add to this, simply removing the constraint on click would be enough to solve these problems (assuming pybetter doesn't have issues on Click 8).

- click = "^7"
+ click = ">=7"

Right now libraries that require Click ^8.0 cannot have pybetter installed in the same environment.

Here's a similar PR for another project for more details.

lensvol commented 2 years ago

I've just released version 0.4.1 which bumps the required click version from 7 to 8. Please give it a try and report if it still does not work for you!

P.S. Sorry for the delay, global chaos has had detrimental effects on my creativity. :(

paw-lu commented 2 years ago

Nothing to be sorry about at all. Grateful for the work shared here! Take your time!