search

lenticularis39 / axpbox

AXPbox Alpha emulator
GNU General Public License v2.0
165 stars 16 forks source link

Arguments to serial console program don't allow spaces #6

Open lenticularis39 opened 4 years ago

lenticularis39 commented 4 years ago

The command for the serial console program doesn't allow parameters with spaces (quotes don't work).

wboerhout commented 3 years ago

is this why I get a "Segmentation fault" when my command is action = "/usr/bin/putty -load /home/pi/.putty/sessions/132x40 -telnet -P 21264 localhost"

RaymiiOrg commented 3 years ago

I'm having trouble reproducing this, with the same command parameters:

afbeelding

I did get a segfault in the IDE controller related to threading but that doesn't seem to be this issue.

wboerhout commented 3 years ago

Just a coincidence then. I keep getting a segfault in Flash.cpp. Will investigate further and open an issue if it persists Thank you for your efforts with this emulator!

RaymiiOrg commented 3 years ago

This is a stack of the segfault:

std::thread::get_id thread:173
CAliM1543C_ide::run AliM1543C_ide.cpp:2470
CAliM1543C_ide::start_threads()::$_0::operator()() const AliM1543C_ide.cpp:445
std::__invoke_impl<void, CAliM1543C_ide::start_threads()::$_0>(std::__invoke_other, CAliM1543C_ide::start_threads()::$_0&&) invoke.h:60
std::__invoke<CAliM1543C_ide::start_threads()::$_0>(CAliM1543C_ide::start_threads()::$_0&&) invoke.h:95
std::thread::_Invoker<std::tuple<CAliM1543C_ide::start_threads()::$_0> >::_M_invoke<0ul>(std::_Index_tuple<0ul>) thread:244
std::thread::_Invoker<std::tuple<CAliM1543C_ide::start_threads()::$_0> >::operator()() thread:251
std::thread::_State_impl<std::thread::_Invoker<std::tuple<CAliM1543C_ide::start_threads()::$_0> > >::_M_run() thread:195
<unknown> 0x00007f65e688bd84
start_thread 0x00007f65e6bc3609
clone 0x00007f65e6579103

thrController[0] is a nullptr, so i;ll push a fix for that as well. It happens on any telnet connection for me, even without spaces in action or with an empty `action

Do you have a stacktrace maybe or your full es40.cfg or a screenshot?

RaymiiOrg commented 3 years ago

The command for the serial console program doesn't allow parameters with spaces (quotes don't work).

@lenticularis39 do you have a command to reproduce it with? I'd be happy to look into it further.

wboerhout commented 3 years ago

see separate issue I just created