search

lentinj / ie-vm

modern.ie VMs under KVM/QEMU
MIT License
123 stars 15 forks source link

Fixed Linux URL #3

Closed ianblenke closed 9 years ago

ianblenke commented 9 years ago

The URL path pattern has changed for Linux

lentinj commented 9 years ago

Thanks for this! I didn't realise the format had changed and my IE VMs are starting to expire, so need re-downloading. Good timing :)

I'm somewhat nervous of the various rm -f's in the changes though. I'll have a go at neatening them later today and see what you think.

lentinj commented 9 years ago

Have a look at the new-zip-format branch. I think this works, and avoids having to make more temporary files. A bit more testing, and will merge this into master.

I'm guessing this pull request including the VNC option was a mistake? Probably not something to enable by defualt for the world.

ianblenke commented 9 years ago

Including VNC by default was intentional mostly because I'm deploying this on CoreOS hosts on secured VPC segments - it would make sense to bind to 127.0.0.1 though. Good advice!