search

lentschi / ngx-ellipsis

Multiline text with ellipsis for angular 9+
MIT License
96 stars 22 forks source link

ngx-ellipsis does not support @angular/common >= 12.0.0 #58

Closed somehan closed 3 years ago

somehan commented 3 years ago

Trying to upgrade angular to 12.0.1 we run into this error:

npm WARN ngx-ellipsis@3.1.1 requires a peer of @angular/common@>=9.0.0 <12.0.0 || >10.0.0-beta <12.0.0

It would be nice if we could continue using ngx-ellipsis while upgrading angular.

lentschi commented 3 years ago

@somehan This was just a warning - it should have worked fine in angular 12.

Anyhow, I fixed the peer dependency warning in ngx-ellipsis@3.1.2

somehan commented 3 years ago

Thank you! I can confirm that the 3.1.2 works for me (in the sense of not showing the warning any more).

:pray: