search

leo-arch / clifm

The shell-like, command line terminal file manager: simple, fast, extensible, and lightweight as hell.
https://github.com/leo-arch/clifm/wiki
GNU General Public License v2.0
1.33k stars 40 forks source link

icons are not visible in search results #195

Closed deathtrip closed 1 year ago

deathtrip commented 1 year ago

Describe the bug When launching with icons enabled, they are not visible in search results. I'm using the default emoji-icons.

To Reproduce Steps to reproduce the behavior:

  1. Launch clifm with the --icons option
  2. Search for something /mysearch
  3. See the search results with no icons.

Expected behavior Icons should be visible in the results

Desktop:

leo-arch commented 1 year ago

Hi @deathtrip. Thanks for reporting.

Icons were just never added to the list of search results. I'll add this to my TODO list and let you know as soon as I have it working.

leo-arch commented 1 year ago

Hey @deathtrip, now we have icons (and right padded ELN's) in search results too!

EDIT: CWD only.

deathtrip commented 1 year ago

Icons are now there, however the fix introduced 2 empty lines: one after the search term before the results, and another one before the "matches found" summary. They don't match clifm's generally tighter spacing.

leo-arch commented 1 year ago

Great! Extra spacing removed.

leo-arch commented 1 year ago

Should we close this issue then?

deathtrip commented 1 year ago

Yeah, i think we can close it. Thanks for fixing it so quickly. 🥇

leo-arch commented 1 year ago

@deathtrip, thank you for reporting.