leo-arch / clifm

The shell-like, command line terminal file manager: simple, fast, extensible, and lightweight as hell.
https://github.com/leo-arch/clifm/wiki
GNU General Public License v2.0
1.33k stars 40 forks source link

Build failure with -D_NO_ICONS #269

Closed FluffyJay1 closed 7 months ago

FluffyJay1 commented 7 months ago

Describe the bug Build fails if the -D_NO_ICONS flag is set.

To Reproduce Steps to reproduce the behavior:

  1. Run make with the -D_NO_ICONS cflag
  2. Observe the build fails

Expected behavior The build succeeds

Screenshots

src/colors.c: In function ‘get_ext_color’:
src/colors.c:773:39: warning: implicit declaration of function ‘hashme’ [-Wimplicit-function-declaration]
  773 |                 return check_ext_hash(hashme(ext, 0), val_len);
      |                                       ^~~~~~
...
colors.c:(.text+0x1d09): undefined reference to `hashme'
...
colors.c:(.text+0x2100): undefined reference to `hashme'
...
collect2: error: ld returned 1 exit status
make: *** [Makefile:39: clifm] Error 1

Desktop (please complete the following information):

Additional context N/A

leo-arch commented 7 months ago

Thanks @FluffyJay1. It should be fixed now. Give it a try and let me know if it works for you too,

FluffyJay1 commented 7 months ago

awesome, works for me now