search

leo-buneev / eslint-plugin-sort-keys-fix

Fork of https://eslint.org/docs/rules/sort-keys that allows automatic fixing
97 stars 23 forks source link

Fix moving comments #12

Closed osmestad closed 2 years ago

osmestad commented 4 years ago

This is a WIP for fixing issue #2. It handles simple cases of the second example in the ticket, but fails when each entry has a comment. I'm leaving it here if someone is interested in picking it up, for our initial transformation I think we will go for this approach instead: https://github.com/JamieMason/codemods#sort-object-props

Sawtaytoes commented 4 years ago

What's preventing this from being merged? The concept or just no time to review the code?

osmestad commented 4 years ago

I think it does require more work, as this is only a partial fix, but it might be hard to fully support with the API currently exposed by Eslint

vikas-bansal-DisneyPH commented 4 years ago

please mere this @osmestad @Sawtaytoes