leo-health / ios

Leo for iOS allows parents to manage the health of their kids, securely message their care team, and access consumer-friendly medical records.
1 stars 2 forks source link

Discuss: Character limit on free text fields #799

Open nayan-leo opened 8 years ago

nayan-leo commented 8 years ago

There are no backend or front-end limits for character length on free text fields. This includes messages, notes, and comments fields. We should also take a pass at other user entered fields (first name, last name, e-mails, etc) to ensure that we have valid character lengths.

zdrossman commented 8 years ago

@nayan-leo: I think we discussed updating on a field-by-field basis, so here's what I have right now. Please confirm or qualify if you would like changes made:

Notes in PHR: No limit on front-end / Back-end to install limit to ensure we aren't being brought down by gigabyte files.

Messaging: No limit on front-end (as this is consistent with messaging as users see it today in iMessage, whatsapp or facebook messenger); limit on backend for the same reason as above.

Appointment scheduling comments: 600 characters to avoid parents writing essays; same backend limit (? we didn't actually discuss the backend limit on this one, but I see no reason for it to be longer than the front-end limit.) Obviously 600 characters is arbitrary; if we find through experience we need to increase it (or decrease it) we can do so.

zdrossman commented 8 years ago

Please re-assign to me after your review.

nayan-leo commented 8 years ago

@zdrossman This is unrelated but here are the character limits from Athena on demographic / patient specific fields. I wasn't aware of this until recently as the documentation was updated to include character limits. I will reach out to them about free text/description fields.

Field Name Character Limit Lastname field 30 Address1/2 100 City, Guarantor City 30 State, Guarantor State 10 All Zips 10 SSN 13 Employer name 100 Contact name 50 Email 50 Employer city 40 Employer address 80 Name suffix 10

nayan-leo commented 8 years ago

@zdrossman Feel free to start on this while I get a character limit on the appointment comments field.

afanslau commented 8 years ago

Addressed limits for name, email and appointment notes via PR #896

If there are other limits we need to enforce, I'll add them in. If not, we can close this issue