leo-project / erocksdb

Erlang bindings to RocksDB datastore
68 stars 15 forks source link

Feature/checkpoint : add the possibility to do live backups #13

Closed benoitc closed 8 years ago

benoitc commented 8 years ago

See http://rocksdb.org/blog/2609/use-checkpoints-for-efficient-snapshots/ for more infos

benoitc commented 8 years ago

this change extract the checkpoint patch from #11

mocchira commented 8 years ago

@benoitc Thanks as always.

I'd like you to

  1. Remove the commit bump rocksdb...
  2. Add a test case to confirm whether iterator operations also works properly on a db created by Checkpoint
  3. delete checkpoint instead of checkpoint = NULL;
benoitc commented 8 years ago

@mocchira done

mocchira commented 8 years ago

LGTM. Thank you for your contribution.