search

leo-project / erocksdb

Erlang bindings to RocksDB datastore
68 stars 15 forks source link

fix dbobject shutdown #15

Closed benoitc closed 8 years ago

benoitc commented 8 years ago

Original patch was modifying the DbObject instance, I missed that change. This PR fix it.

mocchira commented 8 years ago

@benoitc good catch!

In this case, Eventually RocksDB automatically has freed unreleased all snapshots though we need to detect this kind of mistakes in advance (unfortunately static analysis tools couldn't at this time). This is now on the list.

Anyway, thank you for your contribution.