search

leo / electron-next

Build Electron apps using Next.js
https://github.com/leo/site/blob/beef3a7dc1dfd435a9d8377e3b1b59761ccb7fc7/pages/2017/electron-next.js
MIT License
548 stars 41 forks source link

Fix/next6 #19

Closed hellais closed 6 years ago

hellais commented 6 years ago

I originally based this on the fix by @zawupf, but then realised it's perhaps more robust (and understandable) to improve the check for the path prefix.

romanenko commented 6 years ago

@leo I've tested this PR with next@6 and it works really well! Would you, please, consider checking it out?

jeffscottward commented 6 years ago

What the status on this?

hellais commented 6 years ago

I have been using this for a while in an app I am developing and haven't noticed any problems with it.

It would be great if it were upstreamed.