leo / material-ui

A modern UI for Atom
https://atom.io/themes/material-ui
MIT License
30 stars 6 forks source link

Folder icon looks odd when opened #14

Closed saadq closed 7 years ago

saadq commented 7 years ago

When I open a folder that isn't the root directory of my project, the right border of the icon looks quite uneven as you can see here:

screen shot 2016-08-24 at 3 43 42 pm

It looks like it has to do with this code:

.tree-view .icon-repo:after, .tree-view .icon-file-directory:after {
    content: '';
    display: block;
    top: 9px;
    left: 4px;
    width: 13px;
    height: 8px;
    background: #263238;
    position: absolute;
    transition: transform 100ms;
    transform: scale(0);
}

If I change left: 4px; to left: 3px;, then it seems to fix the issue:

screen shot 2016-08-24 at 3 44 09 pm

Is this an issue or was this difference in the folder icon an intentional style choice?

And I'm on a 15" MBP btw if that matters.

leo commented 7 years ago

Your change is actually correct: There's definitely a bug which makes the folder icon look odd. Would you be interested in sending a PR? 😊

saadq commented 7 years ago

Thanks for the quick reply! I sent a pull request :)

Edit: Going to close this for now and make sure it isn't just a local issue due to the comments made in that pull request ^.