leo60228 / VanillAA-Shaders

Vanilla, but with TAA
Mozilla Public License 2.0
28 stars 7 forks source link

Please add handheld dynamic lights #8

Open wezap opened 1 year ago

wezap commented 1 year ago

Is good because it's not laggy like lambdynamiclights which is the only way to get dynamic lights with this shader on iris right now.

leo60228 commented 1 year ago

I don't see any reason LambDynamicLights would be slower than dynamic lights implemented in a shader. I use LambDynamicLights with this shader myself and don't have performance issues, maybe it's a hardware-specific bug you should report to the dev?

I'm not necessarily ruling this out, but the primary purpose of this shader is just anti-aliasing, and I don't really want to spend a ton of effort on adding this when there's already a compatible solution.

wezap commented 11 months ago

This is amazing. Relevant because lambdynamiclights doesn't work now with the latest version of sodium. Thank you.

Felix14-v2 commented 10 months ago

I don't see any reason LambDynamicLights would be slower than dynamic lights implemented in a shader

Well, on some systems LDL performs extremely slow. You can check the example here: Additive#36