leoafarias / sidekick

A simple app to make Flutter development more delightful
BSD 3-Clause "New" or "Revised" License
1.57k stars 101 forks source link

Fix appimage linux GitHub Action #223

Closed Vinzent03 closed 1 year ago

Vinzent03 commented 2 years ago

I'm currently unsure, whether this project supports Linux or not. You state it in the readme multiple times, but there is no installer in the new release. 0.2.0 had one. Your wiki about installing states that Linux is "coming soon".

I'm currently using 0.2.0 on Ubuntu 20.04 and it's working great! Thank you.

aguilaair commented 2 years ago

Hey!

Yes, Sidekick does support Linux, we were having some CI issues and therefore were having issues building the binaries, I will try and see if I can build them manually today.

Wiki-wise, we just haven't had time to write up install instructions, if you could make a quick guide I can put it up :)

aguilaair commented 2 years ago

@Vinzent03 I have added the binaries, could you test the app image for me please?

https://github.com/fluttertools/sidekick/releases/download/1.0.0/sidekick-linux-1.0.0.AppImage https://github.com/fluttertools/sidekick/releases/download/1.0.0/linux-1.0.0.zip

Vinzent03 commented 2 years ago

@aguilaair When starting via terminal I get the following error: (process:134760): GLib-CRITICAL **: 17:54:11.654: g_file_test: assertion 'filename != NULL' failed

Then I get a pop-up from AppImageLauncher. After confirming the execution in the pop up I get another message in the terminal:

/tmp/.mount_sidekiXy8Thf//Sidekick: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /tmp/.mount_sidekiXy8Thf//Sidekick)

Then the process exists.

aguilaair commented 2 years ago

Thanks, I built it with Ubuntu 22.04, so GLIBC_2.34 may not be available in your specific distro and version, I'll try and compile in 18.04 LTS and upload a new one.

Thanks for getting back to me so quickly

aguilaair commented 2 years ago

@Vinzent03 updated, can you try now?

Vinzent03 commented 2 years ago

Using Sidekick-latest-x86_64.AppImage

It's starting, but it doesn't detect Git, FVM and Brew. Missing brew is correct, but of course I have git and fvm installed. In addition, I get the following messages:

(process:25681): GLib-CRITICAL **: 15:45:55.375: g_file_test: assertion 'filename != NULL' failed
Gtk-Message: 15:46:05.346: Failed to load module "colorreload-gtk-module"
Gtk-Message: 15:46:05.347: Failed to load module "window-decorations-gtk-module"
Gtk-Message: 15:46:05.347: Failed to load module "appmenu-gtk-module"

After clicking Ignore, it correctly lists my flutter version and upgrading my beta channel works too.

aguilaair commented 2 years ago

Ok I will work on Git detection for Linux, it seems it is currently failing to detect it if it is not installed using Brew.

If you type fvm in the terminal, do you get an output? Sidekick bundles it's own version that is separate so it's ok if it is not installed globally.

aguilaair commented 2 years ago

May I close this issue and open a different one for the Compat check fialing?

Vinzent03 commented 2 years ago

Sure, thanks for providing the missing Linux binaries.

aguilaair commented 2 years ago

Great, of course, thanks for being patient regarding Linux support :)

aguilaair commented 2 years ago

Opened #224

Vinzent03 commented 2 years ago

The Linux Binaries are missing again in the 1.1.0 release. The wiki is still outdated as well.

aguilaair commented 2 years ago

The wiki just refers to the guide coming soon, not that the version is coming soon. Feel free to contribute to fix it :)