search

leoafarias / sidekick

A simple app to make Flutter development more delightful
BSD 3-Clause "New" or "Revised" License
1.57k stars 101 forks source link

Duplicate releases displayed (add arch differentiation on MacOS) #246

Closed DanMossa closed 2 years ago

DanMossa commented 2 years ago

I'm running this on an m1 mac mini.

image
aguilaair commented 2 years ago

What's the issue here? Are there's versions not installed?

DanMossa commented 2 years ago

Sorry, by multiple I meant duplicate. Every version has a duplicated row

karniv00l commented 2 years ago

I'm seeing the same

Screenshot 2022-07-01 at 22 34 27
aguilaair commented 2 years ago

I'm seeing the same

Screenshot 2022-07-01 at 22 34 27

Is this also in an M1 Mac?

karniv00l commented 2 years ago

Ah sorry - yes

MacBook Pro 16, Apple M1 Max
macOS Monterey 12.4

Any way I can help you debugging this?

aguilaair commented 2 years ago

I don't have a Mac, so if you could clone the project, figure out what's happening and push a PR that'd definitely help 😂😜

Otherwise we'll have to wait on @leoafarias to be able to take a look :)

karniv00l commented 2 years ago

Ok, got it.

Since Flutter is being built for both x64 and arm64 platforms, we have more versions to choose from. See releases.json: https://raw.githubusercontent.com/fluttertools/fvm/main/releases_macos.json

This would require some work to indicate architectures in both the Sidekick UI and fvm cli.

fvm releases

...
Apr 13 22  │ 2.13.0-0.1.pre
Apr 13 22  │ 2.13.0-0.1.pre
Apr 18 22  │ 2.10.5
Apr 20 22  │ 2.13.0-0.2.pre
Apr 20 22  │ 2.13.0-0.2.pre
Apr 27 22  │ 2.13.0-0.3.pre
Apr 27 22  │ 2.13.0-0.3.pre
May 5 22   │ 2.13.0-0.4.pre
May 5 22   │ 2.13.0-0.4.pre
May 11 22  │ 3.0.0
May 11 22  │ 3.0.0
May 20 22  │ 3.0.1
May 20 22  │ 3.0.1
May 26 22  │ 3.1.0
May 26 22  │ 3.1.0
Jun 10 22  │ 3.0.2
Jun 10 22  │ 3.0.2
Jun 15 22  │ 3.1.0-9.0.pre
--------------------------------------
Jun 15 22  │ 3.1.0-9.0.pre     beta
--------------------------------------
Jun 22 22  │ 3.0.3
Jun 22 22  │ 3.0.3
Jul 1 22   │ 3.0.4
--------------------------------------
Jul 1 22   │ 3.0.4             stable
--------------------------------------
karniv00l commented 2 years ago

FVM issue: https://github.com/fluttertools/fvm/issues/437

leoafarias commented 2 years ago

@karniv00l I will have to take a look as we have to now change the display logic... But should not affect the installation, just the display. Will filter out the releases based on architecture

aguilaair commented 2 years ago

Partial solution comitted, still waiting on arch-based solution, must be provided through FVM, @leoafarias

aguilaair commented 2 years ago

Available in 1.1.0