search

leoafarias / sidekick

A simple app to make Flutter development more delightful
BSD 3-Clause "New" or "Revised" License
1.57k stars 101 forks source link

why does isFvmInstalled() check for git executable #312

Closed prasadsunny1 closed 2 months ago

prasadsunny1 commented 7 months ago

I was exploring how sidekick executes shell commands and found isFvmInstalled check for git, I think its a mistake and it should be checking for fvm instead.

https://github.com/fluttertools/sidekick/blob/356124bea7bc3c9bcd0373f1903a836d2204c569/lib/src/modules/compatibility_checks/compat.utils.dart#L23C2-L29C2

Future<bool> isFvmInstalled() async {
  final fvmRes = await which("git");
  if (fvmRes != null) {
    return true;
  }
  return false;
}
aguilaair commented 7 months ago

yep! FVM comes included with Sidekick so the check might not even be needed

charles0122 commented 2 months ago

@aguilaair We can close this issue.