search

leoasis / react-sound

Sound component to play audio in your web apps
ISC License
491 stars 80 forks source link

Add Buffer Handler #59

Closed robotnealan closed 6 years ago

robotnealan commented 6 years ago

This PR adds a onBufferChange prop method handler for changing buffer state based on SM2s own internal onbufferchange method. Rather than pass the entire SMSound this object it only returns a boolean that can then be used to modify the UI as necessary.

Also adds relevant info to README

robotnealan commented 6 years ago

Hey @leoasis — is there any chance of getting this merged in? If there's any changes you'd want before doing so just let me know.

leoasis commented 6 years ago

Hey @robertnealan sorry for taking too long reviewing this PR, this looks great, I'm merging it. Thanks for the contribution!