search

leoasis / react-sound

Sound component to play audio in your web apps
ISC License
491 stars 80 forks source link

Mute feature? #78

Open dkadrios opened 5 years ago

dkadrios commented 5 years ago

Any chance of there being a mute property that's independent of the volume setting? Right now I have to use external state to remember the last volume setting and then set the actual volume to zero in order to mute. This adds overhead and a bit of complexity when displaying volume controls. It'd be great if react-sound took care of handling mute internally. I presume mute is a common enough feature.

dkadrios commented 5 years ago

Ah, I just noticed @frank780117 has added this in commit https://github.com/frank780117/react-sound/commit/a2b552cdcf210bb64dd6a83a870c1ed57bbe1cb6

It's sure would be great to get a PR for that feature! :)

dkadrios commented 5 years ago

Turned out that the PR from frank780117 was incomplete.

I've submitted a PR that fully implements the mute feature in https://github.com/leoasis/react-sound/pull/79