search

leoasis / redux-immutable-state-invariant

Redux middleware that detects mutations between and outside redux dispatches. For development use only.
MIT License
937 stars 37 forks source link

add support for circular references in actions #6

Closed nkrigsman closed 8 years ago

nkrigsman commented 9 years ago

We bumped into this issue while using this lib with redux-router.

It seems like redux-router dispatches actions with circular references which was throwing errors.

This PR uses json-stringify-safe to do the stringifying to prevent the error.

leoasis commented 8 years ago

@nkrigsman first of all, thanks a lot for contributing and also with tests!! Thank you very much.

Also, sorry for not seeing this sooner, been very busy with other stuff, you know :P I've made some changes into the logic of detecting mutations to fix a bug and moved stuff around, making this PR not mergeable now. Would you mind fixing this? I'll merge afterwards :D

tikotzky commented 8 years ago

Hi @leoasis, The PR has been updated as is now mergable :smile:

leoasis commented 8 years ago

awesome, thanks!

tikotzky commented 8 years ago

Thanks for merging. Can you publish the updated version. npm is still showing 1.1.1

leoasis commented 8 years ago

Yes, will do that today

On Thursday, November 12, 2015, Mordy Tikotzky notifications@github.com wrote:

Thanks for merging. Can you publish the updated version. npm is still showing 1.1.1

— Reply to this email directly or view it on GitHub https://github.com/leoasis/redux-immutable-state-invariant/pull/6#issuecomment-156221713 .

tikotzky commented 8 years ago

:+1: Thanks!

leoasis commented 8 years ago

Done!

tikotzky commented 8 years ago

Thanks!