fix for broken tests? - Githubissues

leoasis / redux-immutable-state-invariant

Redux middleware that detects mutations between and outside redux dispatches. For development use only.

MIT License

937 stars 37 forks source link

fix for broken tests? #8

Closed jebeck closed 8 years ago

jebeck commented 8 years ago

Hi @leoasis, when I forked and cloned this project to work on something (for which I will open another PR), I had failing tests locally. I think maybe these just slipped by since you don't have Travis (or another CI) running on the main repo. Can you verify that the change I've made - changing the expectation for path to provide array indices as strings, not integers - is correct?

I also added a Travis config and the build badge in the README.

leoasis commented 8 years ago

Hey @jebeck! First of all, thanks for sending a PR for this. You're right, it seems I was using an old installed version of expect, and updating it seems to have uncovered the error. Thanks for the fix and also thanks for adding the travis config!