search

leobalter / goiabada

experimental project providing a very simple (and incomplete) unit test tool written using ES6 features.
Other
25 stars 4 forks source link

Future friendly code style #18

Closed HenriqueSilverio closed 9 years ago

HenriqueSilverio commented 9 years ago

Some JSHint options used, are marked as deprecated in favor of JSCS.

JSHint JSCS
immed requireParenthesesAroundIIFE
maxlen maximumLineLength
newcap requireCapitalizedConstructors
trailing disallowTrailingWhitespace

This updates for these new directions... =]

Additionally, sets properties in the globals options to false, to prevent unexpected attributions to these globals.

Edit:

  1. After submitting the pull request, I see which it's related with #10.
  2. One CI build check has failed and I dont know why, and how make it pass... some tips?

Thanks!

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 84.44% when pulling 375aac18fd8d2ca82ccd7c765b9e7f01bde0e015 on HenriqueSilverio:code-style into 27b4dd6ecdda19a3d956ad7e13ba16c87a22e375 on leobalter:master.

leobalter commented 9 years ago

the CI failure was due to some Travis issue.

leobalter commented 9 years ago

thanks!