leocaseiro / angular-chosen

AngularJS Chosen directive is an AngularJS Directive that brings the Chosen jQuery in a AngularJS way
http://leocaseiro.github.io/angular-chosen/
MIT License
682 stars 248 forks source link

data-placeholder and placeholder-text-single documentation bug #228

Closed goldbergjeffrey closed 7 years ago

goldbergjeffrey commented 7 years ago

Please mark the options you have done, before open this Issue. We'll prioritize the issues that are consistent and completed.

While I see this isssue closed in #181 , the documentation refers to using data-placeholder in the example: image

and the placeholder-text-single reference does not state single quotes need to wrap the string along with double quotes.

Docs show: image

but reading through #181 I found that placeholder-text-single="'Select a user...'" is what is required to make it work.

jg

leocaseiro commented 7 years ago

Hi @goldbergjeffrey,

Thank you for reporting this issue. I've updated the documentation plunker demo. It supposed to be exactly what you meant: placeholder-text-single="'Select a user...'"

Thanks for that.

carmat commented 7 years ago

FYI, the docs here still refer to data-placeholder instead of placeholder-text-single.

leocaseiro commented 7 years ago

Hi @carmat, thanks for pointing that out, I'll fix the docs by this weekend, I'll open an issue so I won't forget it. Thanks