search

leocavalcante / encrypt

🔒 A set of high-level APIs over PointyCastle for two-way cryptography.
BSD 3-Clause "New" or "Revised" License
348 stars 142 forks source link

AES-GCM encryption #23

Open na2axl opened 5 years ago

na2axl commented 5 years ago

Hi @leocavalcante, I want to know if it is (or if it will be) possible to encrypt/decrypt using AES and the Galois/Counter Mode (GCM) with your library.

Thanks by advance :smile:

leocavalcante commented 5 years ago

Hi @na2axl Since this lib is a wrapper around PointyCastle, I need this mode landed there first :/ https://github.com/PointyCastle/pointycastle/tree/master/lib/block/modes I'vent sufficient knowledge to implement one hehe

robindijkhof commented 3 years ago

I think this issue should be reopened. Since the start of this year PointyCastle does support AES GCM.

leocavalcante commented 3 years ago

Thanks for the headsup.

edthedev commented 3 years ago

The Safer Illinois application uses this library and received criticism for lacking AES/GCM. I am watching this issue in case I can assist in some way when this feature is ready to release.

soatok commented 3 years ago

PointyCastle has also been archived by its developer. It's probably safe to say it's abandoned. I was mistaken, see next comment.

soatok commented 3 years ago

Correction: Their code lives in a different repository than what was linked.

I've submitted a security report to PointyCastle about a timing-leak in their AES-GCM implementation: https://github.com/bcgit/pc-dart/issues/140

soatok commented 3 years ago

Also, their AES leaks keys via cache-timing. https://github.com/bcgit/pc-dart/issues/141

Probably worth keeping in mind for https://github.com/rokwire/safer-illinois-app/issues/687

Arcttyx commented 2 years ago

will this functionality be added in the future? I would like to use the same package for AES-GCM and RSA and signing, so this one looks good :)