search

leocb / MaterialSkin

Theming .NET WinForms, C# or VB.Net, to Google's Material Design Principles.
MIT License
438 stars 132 forks source link

ContextMenuTranslation #255

Closed valimaties closed 2 years ago

valimaties commented 2 years ago

Added ContextMenuTranslation to BaseTextBox and to MaterialTextBox, MaterialTextBox2, MaterialMultiLineTextBox2 and MaterialMaskedTextBox. This will close #250

orapps44 commented 2 years ago

Hi @valimaties ,

Context menu translation is a good enhancement. In your approach we need for each control to update ContextMenuTranslation for each control. For a language, translation will allways be the same, so from my point of view we shouldn't do this way.

Instead I propose similar approach than FlexibleMaterialDialog (translation hard coded) base on CurrentUICulture. Then everyone interested in a specific language can contriburte with PR.

PS: did you try PR code ? Text translation works but no action occurs after click ...

valimaties commented 2 years ago

Hi @valimaties ,

Context menu translation is a good enhancement. In your approach we need for each control to update ContextMenuTranslation for each control. For a language, translation will allways be the same, so from my point of view we shouldn't do this way.

Instead I propose similar approach than FlexibleMaterialDialog (translation hard coded) base on CurrentUICulture. Then everyone interested in a specific language can contriburte with PR.

PS: did you try PR code ? Text translation works but no action occurs after click ...

Hi @orapps44 . Yes, Ive tried before commit. Mine works. I will try it again. Yes, indeed, I think about this approach, and the fact that every control must be modified in Design. But is what I find as a quick solution and viable.

Ok, I will think at another way of doing it!