MaterialButton HighlightOnFocus property

leocb / MaterialSkin

Theming .NET WinForms, C# or VB.Net, to Google's Material Design Principles.

MIT License

438 stars 132 forks source link

MaterialButton HighlightOnFocus property #284

Closed valimaties closed 2 years ago

valimaties commented 2 years ago

Setting this property to True will apply a percent of lighting or darker color, based on Theme used and type of button. It uses ControlPaint.Light(Color, percentDarkDark) or ColorPaint.Dark(Color, percentDarkDark) method. As long as this is a bool property and it is not set in MaterialButton's constructor, this PR will not affect any project, by default it is false, the buttons will have old MaterialSkin approach.

This will close #279

Demo: MaterialButtonHiglight

orapps44 commented 2 years ago

Hi @valimaties ,

I see some issues in your PR.

Adding a property isn't necessary.
Tab Highlighting is different than mouse over.
Once highlighted, button will remain highlighted until mouse goes over it (so on same form you may have two highlighted buttons at the same time which is bad.

orapps44 commented 2 years ago

I've prepared quickly a new PR #285 that basically add this feature with less code modifications. Try it and let me know.

valimaties commented 2 years ago

Mine works as I expected, I don't know what you are saying about. As it is shown in demo gif, everything works as I expected. But I will try your PR...

valimaties commented 2 years ago

I have tried your PR, but it does not do anything! Or you did not understood what FocusVisibility means... Or on my installation simply does not do anything. Please, could you make a gif or something of what you see on those buttons when you press Tab key? I don't see any change on buttons.