search

leocb / MaterialSkin

Theming .NET WinForms, C# or VB.Net, to Google's Material Design Principles.
MIT License
438 stars 132 forks source link

Nuget MaterialSkin2 2.3.0 not fully supported in .Net5 solution #287

Closed valimaties closed 2 years ago

valimaties commented 2 years ago

NotFullySupported

VolatilePulse commented 2 years ago

@orapps44 I didn't even see that you published a NuGet package. How did you build the package?

Edit: The NuGet package was created incorrectly as can be seen by the Dependencies section on NuGet: image

In case you had forgotten, I configured the MaterialSkinCore project to create a NuGet package for you. You can view my comment on that PR here . Pending any changes that I may have missed, simply right clicking on the Core project and selecting Pack will create a NuGet package for you that is already multi-targeted.

Be aware that I left the Package Version at 2.2.1. It can be changed via Core project properties. Select Package in the properties screen and look for Package Version to set it to 2.3.0.

orapps44 commented 2 years ago

Package was build using 'nuget pack' command.

I ve tried to make a new package but didn't succeed to update .nuspec file correctely to integrate dll for net5.0. neither to create package from MaterialSkinCore.csproj. Could you advise me what command should I use to create proper nuget package ?

valimaties commented 2 years ago

In VS 2019 (2022) there is a Pack command when you right click on project. Attached bin folder created by me using Pack option in contextual menu of my VS2022 installation. The location of bin folder is in MaterialSkin folder Location

bin.zip

valimaties commented 2 years ago

Hi @orapps44
Did you used bin folder generated?

orapps44 commented 2 years ago

simply right clicking on the Core project and selecting Pack will create a NuGet package for you that is already multi-targeted.

Thank you, I did release new multi-targeted package version 2.3.1 on nuget.

It should be published within few hours.