search

leocb / MaterialSkin

Theming .NET WinForms, C# or VB.Net, to Google's Material Design Principles.
MIT License
438 stars 132 forks source link

Designer Generated Properties for Material Controls #290

Open VolatilePulse opened 2 years ago

VolatilePulse commented 2 years ago

When creating or modifying an existing control using the Visual Studio designer, lots of unnecessary properties are set that make the control properties hard to navigate, and some even alter the appearance or functionality of the control. For example, I just made a change for my last issue and when I saved it, I ended up with a lot of default values being set.

image

Additionally, all MaterialButtons have 2 properties added to them, AccentTextColor and NoAccentTextColor. These properties affect the visual appear of the buttons when using any theme other than the default one and whenever the button type is set to Outlined.

This specific issue should be converted into a discussion about what properties should be auto generated by the designer, which properties can be hidden by the designer (including base class properties like Font, BackColor, etc.), and how each of the properties should be addressed. You know I've been working on the MaterialForm class and I can continue to demonstrate what's possible with that class if you'd like, but I need direction. Consider an open discussion about design principles and what goals this library has in mind.

As always, I am open for discussion using a better medium. If you'd like, you can contact me on Discord via Mr. Plow#0001. If you'd prefer to an alternative medium for discussion, I'm open to other options. We could even just create a single issue here for the community to chime in, but some times it can be cumbersome to receive feedback. I do feel that any conclusions that are drawn should be made visible for the community to critique the decisions though.

orapps44 commented 2 years ago

So far I've been focused to add controls and improved exisiting with respect to Material specification (as much as possible) and also fix issues as much as I can. This is allready consuming a lot of my time ... I appreciate a lot you work and I'm glad you can participate to improve this project.

I agree with you, there is probably some work around unnecessary properties generated by designer, but I didn't focus on it yet.

Regarding communication, I think we can keep actual way (only 3 peoples including you and me are currentely active...).

I suggest to make one PR per control regarding properties improvements.

Regarding other improvements I have in mind following ones : . Drawer form rework (see #244) . Text field language translation (see beta PR #260) . Performance improvements ...

Do you see any other improvements on your side ?