leocb / MaterialSkin

Theming .NET WinForms, C# or VB.Net, to Google's Material Design Principles.
MIT License
439 stars 131 forks source link

[Improvement suggestion] Title bar buttons are too small for some use cases #361

Open progmars opened 2 years ago

progmars commented 2 years ago

One of Google's Material Design concepts is supporting touchscreens. However, with MaterialSkin library the title bar buttons are reduced in size and seem located closer together when compared to Windows default style. It would be awesome to be able to adjust the title bar height (which, in turn, would make buttons larger) to better support touchscreens and users with "fat fingers".

By the way, in the code title bar is called STATUS_BAR_HEIGHT, which is confusing because status bar in Windows is an entirely different thing (it's the bar at the bottom of the window).

Actually, maybe I will try to implement configurable title bar height myself and I hope I won't mess things up; there are lots of elements depending on STATUS_BAR_HEIGHT.

valimaties commented 2 years ago

Hi @progmars I don't think @leocb maintain this project anymore... There are some PR that was not merged in the master branch. It is hard for those who want to add some improvements on this project but the PR or opened issues are not solved. So, I suggest to fork this project and do yourself the job you want to do if you want to use this project in the future. Personally, I have switched to WPF because it is more powerful when comes to build animations, layers, custom styling objects and so on πŸ™‚ Myself, I stopped using WinForms. I have only a project made in WinForms using MaterialSkin, so I don't think I'm using this one in the future. Good luck! πŸ€—πŸ‘Œ

progmars commented 2 years ago

Thanks @valimaties , you are right, it's time to move on. I'm also looking at MAUI as it seems to be a "cross-platform WPF", but it still lacks some important bits (or they are difficult to implement or are unstable).

Meanwhile, I'll try to hack something up to make my old WinForms app work as expected, while I have not ported it to WPF or MAUI yet.

leocb commented 2 years ago

Hi, it's been a while :)

@valimaties is right, I don't maintain this project anymore and I STRONGLY recommend you move on to more modern UI frameworks such as WPF, UWP ou MAUI, honestly, even give electron with react a chance, if you can.

In the past I gave full access to @orapps44 and they made significant improvements after me, but I don't think they are maintaining it anymore, too

The Open PRs are open because they either A: don't meet the (little) code quality we have or mess with things they shouldn't, or B: we requested changes and the person responsible for the PR never made them

I forked this code a long time ago, and it already wasn't that great, and I think I'd do a lot of things differently now that I am a more experienced C# developer. I'm honestly thinking to mark this project as deprecated on nugget so ppl stop using it for new projects and just use wpf. This should be only used on legacy software

valimaties commented 2 years ago

Hi @leocb . I wanted to tag @orapps44 but I don't know why I tagged you πŸ˜‚πŸ˜ Yes, we know you don't maintain this project, but in the last month (or two, I don't know) neither @orapps44 maintain it... And it is understandable, as long as (as you said) this could be made in other way, and definitely is better to move on and to programming in WPF or other ones which helps us more than WinForms. As I said, this project I used only in one solution/project at my work, and for some time I started to rewrite my project entirely from scratch using WPF, which I think is more complex and more customizable than WinForms. I give you one bigπŸ‘for the idea of marking this project deprecated.

Sorry for the OffTopic!!!

Best regards, Vali